Fix PropertyValueColumnData._stream() to handle rollover >= len(L)
#13318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quasiben can you do a quick test with this patch? |
xiaoyang-sde
changed the title
PropertyValueColumnData._stream() to handle rollover >= len(data)PropertyValueColumnData._stream() to handle rollover > len(data)
xiaoyang-sde
changed the title
PropertyValueColumnData._stream() to handle rollover > len(data)PropertyValueColumnData._stream() to handle rollover >= len(L)
Codecov Report
@@ Coverage Diff @@
## branch-3.3 #13318 +/- ##
===========================================
Coverage 92.45% 92.45%
===========================================
Files 315 315
Lines 20150 20150
===========================================
Hits 18629 18629
Misses 1521 1521 |
|
Thanks @xiaoyang-sde -- locally testing verified this resolves the bug! |
bryevdv
approved these changes
Aug 9, 2023
|
Thanks for the quick turnaround @xiaoyang-sde! will merge now and backport for a 3.2.2 in the next few days |
bryevdv
pushed a commit
that referenced
this pull request
Aug 11, 2023
#13318) * Fix PropertyValueColumnData._stream() to handle rollover >= len(data) * Clean implementation
Merged
bryevdv
pushed a commit
that referenced
this pull request
Aug 12, 2023
#13318) * Fix PropertyValueColumnData._stream() to handle rollover >= len(data) * Clean implementation
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
bokeh#13318) * Fix PropertyValueColumnData._stream() to handle rollover >= len(data) * Clean implementation
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13314
If
rollover >= len(L), there's no need to delete items fromL.