Improve performance of invalidation of refs in bokehjs #13334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-3.3 #13334 +/- ##
==============================================
- Coverage 92.45% 92.44% -0.01%
==============================================
Files 315 315
Lines 20152 20156 +4
==============================================
+ Hits 18631 18634 +3
- Misses 1521 1522 +1 |
bryevdv
approved these changes
Aug 18, 2023
| @@ -463,6 +545,10 @@ export namespace Kinds { | |||
| override toString(): string { | |||
| return `NonNegative(${this.base_type.toString()})` | |||
| } | |||
|
|
|||
| may_have_refs(): boolean { | |||
| return this.base_type.may_have_refs() | |||
There was a problem hiding this comment.
What is an example of a case where this is true?
There was a problem hiding this comment.
Most likely it will never be true, but for the sake of completeness it's there. In the future I need to add some more structure to those classes, so this will be implemented the same for for all single parameterized kinds. I suppose it could be an optimization to just return false.
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* Improve performance of invalidation of refs in bokehjs * Further optimize HasProps._value_record_references() * Increase test timeout for MacOS in CI
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes bokehjs' properties system aware of refs, making the invalidation of refs less expensive or allowing to skip it altogether. The duality of this design is required both to efficiently handle fully typed properties and those dynamically typed (using
AnyorAnyRefand combinations).