Make it easier to reference models' views

[mattpap]

This makes Bokeh.index a ViewManager with a compatibility layer, so that Bokeh.index[id] still works. I also added access to the index to CustomJS callbacks via a new context (or cb_context) argument. Having such context is useful, because it allows users to avoid using globals, Bokeh specifically, which either may not be available (e.g. in ESM) or can be confusing when loading multiple instances of Bokeh on a page.

Due to issues with testing in my new setup, I had to resolve issue #12625.

TODO:

• tests

addresses #13350
fixes #12625

[codecov]

Codecov Report

Merging #13351 (550eb5a) into branch-3.3 (277fd86) will increase coverage by 0.00%.
The diff coverage is 92.85%.

@@             Coverage Diff             @@
##           branch-3.3   #13351   +/-   ##
===========================================
  Coverage       92.42%   92.43%           
===========================================
  Files             316      316           
  Lines           20209    20218    +9     
===========================================
+ Hits            18679    18688    +9     
  Misses           1530     1530           

[bryevdv]

Really nice changes, just a few comments.

[bryevdv]

@mattpap just noting that #13350 was specifically about resetting from Python. I am not sure that's actually attained by this PR? (I think we'd need a new protocol event that could be triggered from Python to invoke the reset on the JS side)

Edit: I am not opposed to closing the issue with this PR, but I think we should explain the distinction and change in plans and why this is probably all that is needed, in the issue itself.

[bryevdv]

@mattpap as long it's now straightforward to expose reset in this way what you do think about exposing an explicit "request redraw" for users? Current users will try to do things like source.change.emit() to force a redraw (saw it again today)

[mattpap]

in this way what you do think about exposing an explicit "request redraw" for users?

request_render() is the API for this purpose:

export default ({plot}, _target, _data, {index}) => {
    const plot_view = index.get_one(plot)
    plot_view.request_render()
}

[mattpap]

just noting that #13350 was specifically about resetting from Python. I am not sure that's actually attained by this PR? (I think we'd need a new protocol event that could be triggered from Python to invoke the reset on the JS side)

Yeah, I so far overlooked the fact that we don't have any sensible programmatic way of running CustomJS (not attached to any tools or buttons or so).

[mattpap]

I will handle supporting running CustomJS independently of UI controls in another PR.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.