Redesign tooltip around CSS position fixed
#13355
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-3.3 #13355 +/- ##
===========================================
Coverage 92.47% 92.47%
===========================================
Files 315 315
Lines 20184 20184
===========================================
Hits 18665 18665
Misses 1519 1519 |
|
This PR also allows tooltips to fit into viewport if they overflow: |
mattpap
force-pushed
the
mattpap/13347_tooltip_overflow
branch
from
5914e8f to
b97de24
Compare
I'm not sure how I feel about this. Looking at the baseline changes, I am not sure I think swapping the sides is an improvement in all the cases where the sides swapped. I'll need to think about this a bit more . |
This allows tooltips to be completely removed from document flow, which allows to avoid viewport overflow/scrollbars for large tooltips.
mattpap
force-pushed
the
mattpap/13347_tooltip_overflow
branch
from
b97de24 to
278a685
Compare
|
I implemented a combination of the original approach respecting plot box and the new respecting the viewport. |
* Redesign tooltip around CSS position `fixed` This allows tooltips to be completely removed from document flow, which allows to avoid viewport overflow/scrollbars for large tooltips. * Simplify CSS of tooltip's arrow * Position arrow independently of tooltip's contents * Allow to adjust tooltip position to fit viewport * Update baseline images * Respect both target and viewport bbox * Update visual baselines
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This uses CSS position
fixedinstead ofabsolute, which completely removes tooltip from HTML document flow, so no overflow and thus no scrollbars. This resulted in a redesign of tooltip positioning, which in result simplified the implementation. I also made tooltip positioning to respect the viewport instead of the target element when choosing attachment position in auto mode.fixes #13347
fixes #11273