Skip to content

Fix painting of border/background visuals in SVG backend - #13363

Merged
mattpap merged 9 commits into
branch-3.4from
mattpap/13362_plot_visuals
Oct 30, 2023
Merged

Fix painting of border/background visuals in SVG backend#13363
mattpap merged 9 commits into
branch-3.4from
mattpap/13362_plot_visuals

Conversation

@mattpap

@mattpap mattpap commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

image

fixes #13362

@mattpap mattpap added this to the 3.3 milestone Sep 4, 2023
@mattpap mattpap changed the title Fix painting of border/background visual in SVG backend Fix painting of border/background visuals in SVG backend Sep 4, 2023
@codecov

codecov Bot commented Sep 4, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #13363 (abc5908) into branch-3.4 (3497855) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           branch-3.4   #13363   +/-   ##
===========================================
  Coverage       92.62%   92.62%           
===========================================
  Files             321      321           
  Lines           20380    20380           
===========================================
  Hits            18877    18877           
  Misses           1503     1503

@mattpap

mattpap commented Sep 4, 2023

Copy link
Copy Markdown
Contributor Author

images differ by 1px (0.00%)

All of them (1px per plot).

@ianthomas23

ianthomas23 commented Sep 4, 2023

Copy link
Copy Markdown
Member

I've confirmed it fixes the issue, but I'm not sure it is worth the churn of so many baseline image changes 😳

@mattpap

mattpap commented Sep 4, 2023

Copy link
Copy Markdown
Contributor Author

It definitely doesn't make sense to merge this in this state. I need to either figure out where this difference is coming from or combine this with some other large changes (e.g. switching to newer chromium for testing).

@mattpap mattpap modified the milestones: 3.3, 3.4 Oct 4, 2023
@mattpap
mattpap changed the base branch from branch-3.3 to branch-3.4 October 10, 2023 12:45
@mattpap
mattpap force-pushed the mattpap/13362_plot_visuals branch from e8776d9 to 8137540 Compare October 10, 2023 16:06
@mattpap
mattpap force-pushed the mattpap/13362_plot_visuals branch from 8137540 to 4e8d1f9 Compare October 26, 2023 14:57
@mattpap

mattpap commented Oct 26, 2023

Copy link
Copy Markdown
Contributor Author

Originally this PR required update of ~70% of baselines, thus I included also upgrade of Chromium, which on its own requires update ~50% of baselines.

In the context of PR #13453, this is size contribution of this PR:

$ git push -f
(...)
Writing objects: 100% (1187/1187), 21.14 MiB | 4.82 MiB/s, done.
(...)

@mattpap
mattpap force-pushed the mattpap/13362_plot_visuals branch 2 times, most recently from 6d52c40 to 5d98972 Compare October 26, 2023 15:19
@mattpap
mattpap force-pushed the mattpap/13362_plot_visuals branch from 5d98972 to abc5908 Compare October 27, 2023 16:40
ianthomas23
ianthomas23 approved these changes Oct 30, 2023
View reviewed changes

@ianthomas23 ianthomas23 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to proceed with this.

@mattpap
mattpap merged commit 1b6ba36 into branch-3.4 Oct 30, 2023
@mattpap
mattpap deleted the mattpap/13362_plot_visuals branch October 30, 2023 20:35
@ianthomas23 ianthomas23 mentioned this pull request Nov 10, 2023
Merged
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
@mattpap @Chiemezuo
Fix painting of border/background visuals in SVG backend (bokeh#13363)
b7b25b7 
* Implement SVGRenderingContext2D.clip(fill_rule)

* Use a clip path when paining border visuals

* Add visual regression tests

* Update visual baselines

* Require Chromium 118.0.5993.88 (r2670)

* Update visual baselines

* Add comments regarding version updates

* Show installed Chromium's version number

* Don't compare Chromium's patch number
@github-actions

github-actions Bot commented Oct 25, 2024

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ianthomas23 ianthomas23 ianthomas23 approved these changes

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

[BUG] Inconsistent handling of background and border fill alpha

2 participants

@mattpap @ianthomas23