Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to color map non-factors to nan_color #13420

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Oct 10, 2023

fixes #13416

@mattpap mattpap added this to the 3.4 milestone Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #13420 (5c710bf) into branch-3.4 (f166b6f) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           branch-3.4   #13420   +/-   ##
===========================================
  Coverage       92.67%   92.67%           
===========================================
  Files             320      320           
  Lines           20360    20360           
===========================================
  Hits            18868    18868           
  Misses           1492     1492           

Copy link
Member

@bryevdv bryevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@mattpap mattpap force-pushed the mattpap/13416_color_map_NaN_None branch from 465c7a9 to 5c710bf Compare October 10, 2023 17:44
@mattpap mattpap merged commit e8be66b into branch-3.4 Oct 10, 2023
@mattpap mattpap deleted the mattpap/13416_color_map_NaN_None branch October 10, 2023 18:27
@bryevdv bryevdv mentioned this pull request Oct 24, 2023
@bryevdv bryevdv modified the milestones: 3.4, 3.3.1 Oct 31, 2023
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p.rect and possible others in combination with factor_cmap no longer handles NaN values [BUG]
2 participants