Skip to content

Allow to color map non-factors to nan_color#13420

Merged
mattpap merged 1 commit into
branch-3.4from
mattpap/13416_color_map_NaN_None
Oct 10, 2023
Merged

Allow to color map non-factors to nan_color#13420
mattpap merged 1 commit into
branch-3.4from
mattpap/13416_color_map_NaN_None

Conversation

@mattpap

@mattpap mattpap commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

fixes #13416

@mattpap mattpap added this to the 3.4 milestone Oct 10, 2023
@codecov

codecov Bot commented Oct 10, 2023

Copy link
Copy Markdown

Codecov Report

Merging #13420 (5c710bf) into branch-3.4 (f166b6f) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           branch-3.4   #13420   +/-   ##
===========================================
  Coverage       92.67%   92.67%           
===========================================
  Files             320      320           
  Lines           20360    20360           
===========================================
  Hits            18868    18868           
  Misses           1492     1492           

@bryevdv bryevdv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

Comment thread bokehjs/src/lib/models/mappers/categorical_mapper.ts
Comment thread bokehjs/src/lib/models/mappers/categorical_mapper.ts Outdated
@mattpap mattpap force-pushed the mattpap/13416_color_map_NaN_None branch from 465c7a9 to 5c710bf Compare October 10, 2023 17:44
@mattpap mattpap merged commit e8be66b into branch-3.4 Oct 10, 2023
@mattpap mattpap deleted the mattpap/13416_color_map_NaN_None branch October 10, 2023 18:27
@bryevdv bryevdv mentioned this pull request Oct 24, 2023
@bryevdv bryevdv modified the milestones: 3.4, 3.3.1 Oct 31, 2023
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

p.rect and possible others in combination with factor_cmap no longer handles NaN values [BUG]

2 participants