Resolve tooltip positioning issue with contain: strict - #13431
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-3.4 #13431 +/- ##
===========================================
Coverage 92.67% 92.67%
===========================================
Files 320 320
Lines 20360 20360
===========================================
Hits 18868 18868
Misses 1492 1492 |
mattpap
force-pushed
the
mattpap/13428_tooltip_position
branch
from
October 12, 2023 08:41
07cdbef to
16e799e
Compare
bryevdv
approved these changes
Oct 13, 2023
bryevdv
pushed a commit
that referenced
this pull request
Oct 24, 2023
* Resolve tooltip positioning issue with `contain: strict` * Rename : -> _ in baseline names for Windows * Update baseline names
Merged
This was referenced Oct 25, 2023
bryevdv
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Resolve tooltip positioning issue with `contain: strict` * Rename : -> _ in baseline names for Windows * Update baseline names
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* Resolve tooltip positioning issue with `contain: strict` * Rename : -> _ in baseline names for Windows * Update baseline names
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that jlab extensively uses CSS
contain: strict, which introduces a new CSS containing block, which then breaks assumptions aboutposition: fixedthatTooltipuses. This PR fixes this issue and improves tooltip's behavior under scrolling.fixes #13428