Skip to content

Resolve tooltip positioning issue with contain: strict #13431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Oct 12, 2023

The problem was that jlab extensively uses CSS contain: strict, which introduces a new CSS containing block, which then breaks assumptions about position: fixed that Tooltip uses. This PR fixes this issue and improves tooltip's behavior under scrolling.

fixes #13428

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #13431 (16e799e) into branch-3.4 (c942f1a) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           branch-3.4   #13431   +/-   ##
===========================================
  Coverage       92.67%   92.67%           
===========================================
  Files             320      320           
  Lines           20360    20360           
===========================================
  Hits            18868    18868           
  Misses           1492     1492           

@mattpap mattpap force-pushed the mattpap/13428_tooltip_position branch from 07cdbef to 16e799e Compare October 12, 2023 08:41
@mattpap mattpap merged commit 06a410c into branch-3.4 Oct 13, 2023
@mattpap mattpap deleted the mattpap/13428_tooltip_position branch October 13, 2023 18:59
bryevdv pushed a commit that referenced this pull request Oct 24, 2023
* Resolve tooltip positioning issue with `contain: strict`

* Rename : -> _ in baseline names for Windows

* Update baseline names
@bryevdv bryevdv mentioned this pull request Oct 24, 2023
@bryevdv bryevdv modified the milestones: 3.4, 3.3.1 Oct 31, 2023
bryevdv pushed a commit that referenced this pull request Nov 1, 2023
* Resolve tooltip positioning issue with `contain: strict`

* Rename : -> _ in baseline names for Windows

* Update baseline names
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
* Resolve tooltip positioning issue with `contain: strict`

* Rename : -> _ in baseline names for Windows

* Update baseline names
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] HoverTools not correctly located in Notebook
2 participants