Render WebGL markers that have only one of width and height zero #13482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-3.4 #13482 +/- ##
===========================================
Coverage 92.67% 92.67%
===========================================
Files 320 320
Lines 20365 20365
===========================================
Hits 18873 18873
Misses 1492 1492 |
|
Here is a screencast running the code from the attached issue, showing that canvas and webgl now render the same. Screen.Recording.2023-10-24.at.15.09.44.mov |
mattpap
approved these changes
Oct 24, 2023
bryevdv
pushed a commit
that referenced
this pull request
Oct 24, 2023
Merged
bryevdv
pushed a commit
that referenced
this pull request
Nov 1, 2023
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes WebGL rendering of markers (fixed-shape glyphs) so that they are not displayed if both width and height are zero, but they are displayed if just one of width and height is zero and the other is positive.