Skip to content

Conversation

@mattpap
Copy link
Contributor

@mattpap mattpap commented Oct 26, 2023

Adds "stadia." prefix to all tile source queries related to Stamen tiles.

fixes #13490

@mattpap mattpap added this to the 3.4 milestone Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #13491 (d5e69cd) into branch-3.4 (249f2aa) will decrease coverage by 0.02%.
Report is 2 commits behind head on branch-3.4.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           branch-3.4   #13491      +/-   ##
==============================================
- Coverage       92.62%   92.61%   -0.02%     
==============================================
  Files             321      321              
  Lines           20376    20380       +4     
==============================================
+ Hits            18873    18874       +1     
- Misses           1503     1506       +3     

@bryevdv
Copy link
Member

bryevdv commented Oct 26, 2023

@mattpap any updates needed for these?

@mattpap mattpap force-pushed the mattpap/13490_stamen_tiles branch from fac7885 to 98209bf Compare October 27, 2023 08:41
@mattpap
Copy link
Contributor Author

mattpap commented Oct 27, 2023

Seems to work without an API key (at least for now):
image

image

@mattpap
Copy link
Contributor Author

mattpap commented Oct 27, 2023

I updated examples and documentation to use new URLs and attribution.

@mattpap
Copy link
Contributor Author

mattpap commented Oct 27, 2023

Perhaps as a follow-up we should remove bokeh.tile_providers, which was deprecated at 3.0?

@mattpap mattpap force-pushed the mattpap/13490_stamen_tiles branch from 98209bf to d5e69cd Compare October 27, 2023 09:22
@mattpap mattpap merged commit 3497855 into branch-3.4 Oct 27, 2023
@mattpap mattpap deleted the mattpap/13490_stamen_tiles branch October 27, 2023 16:39
@bryevdv bryevdv mentioned this pull request Oct 27, 2023
bryevdv pushed a commit that referenced this pull request Oct 27, 2023
* Replace Stamen* tiles with Stadia.Stamen*

* Update documentation

* Update examples
@bryevdv bryevdv modified the milestones: 3.4, 3.3.1 Oct 31, 2023
bryevdv pushed a commit that referenced this pull request Nov 1, 2023
* Replace Stamen* tiles with Stadia.Stamen*

* Update documentation

* Update examples
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
* Replace Stamen* tiles with Stadia.Stamen*

* Update documentation

* Update examples
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stamen tiles were removed from xyzservices 2023.10.1

3 participants