Skip to content

Multiple density estimate plot#13527

Merged
bryevdv merged 10 commits into
bokeh:branch-3.4from
Azaya89:m-density
Nov 21, 2023
Merged

Multiple density estimate plot#13527
bryevdv merged 10 commits into
bokeh:branch-3.4from
Azaya89:m-density

Conversation

@Azaya89

@Azaya89 Azaya89 commented Nov 13, 2023

Copy link
Copy Markdown
Member

@Azaya89 Azaya89 requested review from bryevdv and mattpap November 13, 2023 19:37
@codecov

codecov Bot commented Nov 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #13527 (71cbadb) into branch-3.4 (c911816) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-3.4   #13527      +/-   ##
==============================================
- Coverage       92.62%   92.57%   -0.05%     
==============================================
  Files             321      323       +2     
  Lines           20451    20464      +13     
==============================================
+ Hits            18943    18945       +2     
- Misses           1508     1519      +11     

Comment thread docs/bokeh/source/docs/user_guide/topics/stats.rst Outdated

@bryevdv bryevdv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further comments

Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
@Azaya89 Azaya89 requested a review from bryevdv November 15, 2023 16:55
@bryevdv

bryevdv commented Nov 15, 2023

Copy link
Copy Markdown
Member

@Azaya89 I see all the conversations marked resolved but no new commits, did you intend to push changes for those comments?

@Azaya89

Azaya89 commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

@Azaya89 I see all the conversations marked resolved but no new commits, did you intend to push changes for those comments?

Yes, but I wanted to resolve the one about the tick formatting before pushing all of them together.

@bryevdv bryevdv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good now, just a couple of final observations

Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
Comment thread examples/topics/stats/density.py Outdated
@Azaya89 Azaya89 requested a review from bryevdv November 16, 2023 21:39

@bryevdv bryevdv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mypy failures are unrelated. Great example!

@mattpap mattpap mentioned this pull request Jan 3, 2024
22 tasks
mattpap pushed a commit that referenced this pull request Jan 4, 2024
* added sample data

* created density plot

* added gallery images and json

* sorted import order

* clarified plot description

* refactored plotting file

* changed tick formatting style

* deleted unused import

* deleted whitespace

* additional file refactoring
mattpap pushed a commit that referenced this pull request Jan 7, 2024
* added sample data

* created density plot

* added gallery images and json

* sorted import order

* clarified plot description

* refactored plotting file

* changed tick formatting style

* deleted unused import

* deleted whitespace

* additional file refactoring
mattpap added a commit that referenced this pull request Jan 8, 2024
* Add a regression test for issue #8890 (#13572)

* Don't register keyup twice in `AutocompleteInput` (#13577)

* Don't register keyup twice in AutocompleteInput

* Pin pytest-asyncio to version 0.21.1

* Link sub-coordinate and context dependent ranges in RangesUpdate (#13603)

* Fix support for global/local imported stylesheets (#13559)

* Compatibility with Chromium 110

* Robustify unit tests involving browser output (#13602)

* Multiple density estimate plot (#13527)

* added sample data

* created density plot

* added gallery images and json

* sorted import order

* clarified plot description

* refactored plotting file

* changed tick formatting style

* deleted unused import

* deleted whitespace

* additional file refactoring

* pyramid example plot (#13596)

* added sample data

* created plot and added plot  description

* added gallery image

* minor edits

* modified plot title

* added bar labels to plot

* removed whitespace

* post-review

* changed color palette

* added plot image

* added extra tick markers

* Remove unnecessary arcTo calls in round_rect (#13627)

* Update license and copyright statements to 2024 (#13630)

* Use `ruff` to ban `typing_extensions` at the top-level (#13633)

* Upgrade to ruff 0.1.11

* Enable TID rules and disable TID252 for now

* Ban `typing_extensions` module at the top-level

* Remove test_no_typing_extensions_common

* Import `typing_extensions` under `TYPE_CHECKING` in `*.pyi`

* Correctly handle transforms in SVG arcTo (#13640)

* ban PIL and other imports with ruff (#13639)

* fix indentation in sphinx extentions (#13549)

* fix indentation in property mixins (#13514)

* fix indentation of default strings with dedent from textwrap

* add missing words in property_mixins.py

* fix indentation in tools.py

* remove dedent block and introduce ALPHA_DEFAULT_HELP and COLOR_DEFAULT_HELP

* change order of imports

* Restored broken API links (#13528)

* restored broken API links

* modified broken API path

* Allow newer tornado and pandas in test-minimal-deps (#13635)

* Add release notes

* Update switcher.json

* avoid_Sphinx ThemeError and set Sphinx to a minimum of 7.1.0 (#13560)

* fix some sphinx warnings (#13609)

* fix some sphinx warnings

* don't make the first line bold

* fix warnings caused by sampledata (#13613)

* add forensic glass and emissions to sampledata.rst (#13615)

---------

Co-authored-by: Azaya <99359668+Azaya89@users.noreply.github.com>
Co-authored-by: Ian Thomas <ianthomas23@gmail.com>
Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com>
@mattpap mattpap modified the milestones: 3.4, 3.3.3 Jan 8, 2024
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
* added sample data

* created density plot

* added gallery images and json

* sorted import order

* clarified plot description

* refactored plotting file

* changed tick formatting style

* deleted unused import

* deleted whitespace

* additional file refactoring
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants