Skip to content

Add support for progress widgets#13546

Merged
mattpap merged 2 commits into
branch-3.7from
mattpap/6556_progress_bar
Feb 28, 2025
Merged

Add support for progress widgets#13546
mattpap merged 2 commits into
branch-3.7from
mattpap/6556_progress_bar

Conversation

@mattpap

@mattpap mattpap commented Nov 23, 2023

Copy link
Copy Markdown
Contributor

From examples/models/widgets.py:

Screencast.from.2025-02-17.13-47-33.webm

fixes #6556

@mattpap mattpap added this to the 3.4 milestone Nov 23, 2023
@codecov

codecov Bot commented Nov 23, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (17b0187) to head (7dd98f7).
Report is 203 commits behind head on branch-3.6.

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-3.6   #13546      +/-   ##
==============================================
+ Coverage       92.58%   92.59%   +0.01%     
==============================================
  Files             325      326       +1     
  Lines           20729    20763      +34     
==============================================
+ Hits            19192    19226      +34     
  Misses           1537     1537              

@mattpap
mattpap force-pushed the mattpap/6556_progress_bar branch from 7295d41 to e0a26fd Compare November 23, 2023 13:31
@mattpap mattpap changed the title Add support progress widgets Add support for progress widgets Nov 24, 2023
@mattpap mattpap modified the milestones: 3.4, 3.5 Jan 11, 2024
@mattpap mattpap added the tag: CSS CSS, styling, theming and widget design. label Jan 11, 2024
@mattpap
mattpap force-pushed the mattpap/6556_progress_bar branch from e0a26fd to 7dd98f7 Compare February 27, 2024 10:34
@mattpap
mattpap changed the base branch from branch-3.4 to branch-3.5 March 14, 2024 16:51
@mattpap mattpap modified the milestones: 3.5, 3.6 Jun 4, 2024
@mattpap
mattpap changed the base branch from branch-3.5 to branch-3.6 July 4, 2024 10:44
@mattpap mattpap modified the milestones: 3.6, 3.7 Sep 26, 2024
@mattpap mattpap added tag: UI: components New or improvements to existing UI components. and removed tag: CSS CSS, styling, theming and widget design. tag: UI: components New or improvements to existing UI components. labels Sep 26, 2024
@mattpap
mattpap changed the base branch from branch-3.6 to branch-3.7 September 26, 2024 16:36
@mattpap
mattpap force-pushed the mattpap/6556_progress_bar branch 4 times, most recently from 444f584 to 871cc77 Compare February 16, 2025 23:16
@mattpap
mattpap force-pushed the mattpap/6556_progress_bar branch from 871cc77 to 5773dec Compare February 16, 2025 23:32
@mattpap

mattpap commented Feb 16, 2025

Copy link
Copy Markdown
Contributor Author

This is tentatively ready. I will still need to add some tests.

@bryevdv
bryevdv requested a review from gabalafou February 17, 2025 01:59
Comment thread bokehjs/src/lib/models/widgets/progress.ts Outdated
@bryevdv

bryevdv commented Feb 17, 2025

Copy link
Copy Markdown
Member

FWIW I like the look of the Vue progress bar better, where the entire bar is the same shade, but "washed out" where it is not yet reached. Maybe that is just something to be done with CSS though.

Comment thread src/bokeh/models/widgets/indicators.py Outdated
Comment thread src/bokeh/models/widgets/indicators.py
@mattpap
mattpap force-pushed the mattpap/6556_progress_bar branch from 5773dec to 55c2ab6 Compare February 17, 2025 11:54
@mattpap mattpap removed the tag: UI: components New or improvements to existing UI components. label Feb 17, 2025
@mattpap

mattpap commented Feb 17, 2025

Copy link
Copy Markdown
Contributor Author

FWIW I like the look of the Vue progress bar better, where the entire bar is the same shade, but "washed out" where it is not yet reached. Maybe that is just something to be done with CSS though.

This is configurable in CSS, but I would leave such discussions for later for CZI theming and the designer. We will work on all components as whole and not just tweaking individual ones.

@mattpap

mattpap commented Feb 17, 2025

Copy link
Copy Markdown
Contributor Author

One thing I don't like about this design is that there is no distinction between an active and inactive (not started, paused, finished) progress component, e.g. so that an active progress could have animations and inactive doesn't (for indication that something is happening or not, but also for performance; CSS animations are very heavy on the CPU).

@mattpap
mattpap force-pushed the mattpap/6556_progress_bar branch 2 times, most recently from a024b34 to 37344e8 Compare February 17, 2025 22:48
@mattpap
mattpap force-pushed the mattpap/6556_progress_bar branch from 37344e8 to 8473d63 Compare February 28, 2025 07:54
@mattpap

mattpap commented Feb 28, 2025

Copy link
Copy Markdown
Contributor Author

Added a user guide documentation entry for the new component.

@mattpap
mattpap merged commit 1bda953 into branch-3.7 Feb 28, 2025
@mattpap
mattpap deleted the mattpap/6556_progress_bar branch February 28, 2025 10:52
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a progress bar to bokeh widgets list

2 participants