Skip to content

Don't register keyup twice in AutocompleteInput #13577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Dec 4, 2023

fixes #13574

@mattpap mattpap added this to the 3.4 milestone Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #13577 (977ea1b) into branch-3.4 (b2b1dd6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           branch-3.4   #13577   +/-   ##
===========================================
  Coverage       92.57%   92.57%           
===========================================
  Files             322      322           
  Lines           20461    20461           
===========================================
  Hits            18941    18941           
  Misses           1520     1520           

@mattpap mattpap force-pushed the mattpap/13574_autocomplete_keyup branch from 72bcbd4 to 977ea1b Compare December 4, 2023 10:29
@mattpap mattpap merged commit cb05144 into branch-3.4 Dec 5, 2023
@mattpap mattpap deleted the mattpap/13574_autocomplete_keyup branch December 5, 2023 08:13
@mattpap mattpap modified the milestones: 3.4, 3.3.3 Dec 21, 2023
mattpap added a commit that referenced this pull request Dec 30, 2023
* Don't register keyup twice in AutocompleteInput

* Pin pytest-asyncio to version 0.21.1
@mattpap mattpap mentioned this pull request Dec 30, 2023
22 tasks
mattpap added a commit that referenced this pull request Jan 8, 2024
* Add a regression test for issue #8890 (#13572)

* Don't register keyup twice in `AutocompleteInput` (#13577)

* Don't register keyup twice in AutocompleteInput

* Pin pytest-asyncio to version 0.21.1

* Link sub-coordinate and context dependent ranges in RangesUpdate (#13603)

* Fix support for global/local imported stylesheets (#13559)

* Compatibility with Chromium 110

* Robustify unit tests involving browser output (#13602)

* Multiple density estimate plot (#13527)

* added sample data

* created density plot

* added gallery images and json

* sorted import order

* clarified plot description

* refactored plotting file

* changed tick formatting style

* deleted unused import

* deleted whitespace

* additional file refactoring

* pyramid example plot (#13596)

* added sample data

* created plot and added plot  description

* added gallery image

* minor edits

* modified plot title

* added bar labels to plot

* removed whitespace

* post-review

* changed color palette

* added plot image

* added extra tick markers

* Remove unnecessary arcTo calls in round_rect (#13627)

* Update license and copyright statements to 2024 (#13630)

* Use `ruff` to ban `typing_extensions` at the top-level (#13633)

* Upgrade to ruff 0.1.11

* Enable TID rules and disable TID252 for now

* Ban `typing_extensions` module at the top-level

* Remove test_no_typing_extensions_common

* Import `typing_extensions` under `TYPE_CHECKING` in `*.pyi`

* Correctly handle transforms in SVG arcTo (#13640)

* ban PIL and other imports with ruff (#13639)

* fix indentation in sphinx extentions (#13549)

* fix indentation in property mixins (#13514)

* fix indentation of default strings with dedent from textwrap

* add missing words in property_mixins.py

* fix indentation in tools.py

* remove dedent block and introduce ALPHA_DEFAULT_HELP and COLOR_DEFAULT_HELP

* change order of imports

* Restored broken API links (#13528)

* restored broken API links

* modified broken API path

* Allow newer tornado and pandas in test-minimal-deps (#13635)

* Add release notes

* Update switcher.json

* avoid_Sphinx ThemeError and set Sphinx to a minimum of 7.1.0 (#13560)

* fix some sphinx warnings (#13609)

* fix some sphinx warnings

* don't make the first line bold

* fix warnings caused by sampledata (#13613)

* add forensic glass and emissions to sampledata.rst (#13615)

---------

Co-authored-by: Azaya <99359668+Azaya89@users.noreply.github.com>
Co-authored-by: Ian Thomas <ianthomas23@gmail.com>
Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com>
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
* Don't register keyup twice in AutocompleteInput

* Pin pytest-asyncio to version 0.21.1
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AutocompleteInput: Arrow up/down skips 2 options, not one by one
2 participants