Repository navigation
Implements Individual Tool Visibility in Toolbar - #13593
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13593 +/- ##
===========================================
Coverage 92.58% 92.58%
===========================================
Files 325 325
Lines 20728 20729 +1
===========================================
+ Hits 19191 19192 +1
Misses 1537 1537 |
Contributor
|
I need to think about this approach in the context of other ongoing work (e.g. PR #13571), i.e. whether it makes sense for tools to be visible or whether it's their UI representation that should carry this setting. |
mattpap
self-requested a review
December 21, 2023 11:15
Contributor
|
I did a little clean up of this PR, deprecated |
mattpap
approved these changes
Feb 16, 2024
Contributor
|
@zoeangell, thanks. |
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* Initial experimentation * Implemented visibility toggle to all tools * Edited comment for visible attribute in tools.py * added basic unit tests for visible * fixed lint errors * Added unit tests for visible and toggleable featuer * adding integration testing * fixed linter errors * fixed linter errors * Refine the implementation * Deprecate InspectTool.toggleable * Properly initialize aliased properties * Don't use toggleable, but rely on visible * Add release notes --------- Co-authored-by: Jacky Gao <jackygao02@andrew.cmu.edu> Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to set a tool's visibility in the toolbar. This was done by adding the visible property to the Python Tool Class and Tool module in bokehjs. We modeled the functionality and implementation of this feature after the toggleable property for InspectTools (e.g. CrosshairTool and HoverTool).
Setting
visible=Falsefor a tool will make it not show up in the toolbar, but it will still have its functionality.To test our feature we wrote Javascript unit tests and integration tests.
Graph with
box_edit = BoxEditTool(visible = True)Graph with
box_edit = BoxEditTool(visible = False)Resolves #8153