Skip to content

Link sub-coordinate and context dependent ranges in RangesUpdate #13603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Dec 14, 2023

This PR allows PlotView.trigger_ranges_update_event() to also consider sub-coordinate and other context dependent ranges. For example, when two plots are indirectly linked by a RangeTool, then previously RangesUpdate would only trigger on the plot that owns the RangeTool, but not on the plot manipulated by the tool. Indirect linking means that plots don't share any ranges.

fixes #13507

@mattpap mattpap added this to the 3.4 milestone Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #13603 (cb6578f) into branch-3.4 (8ef6559) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-3.4   #13603      +/-   ##
==============================================
- Coverage       92.54%   92.53%   -0.01%     
==============================================
  Files             322      322              
  Lines           20463    20463              
==============================================
- Hits            18938    18936       -2     
- Misses           1525     1527       +2     

Copy link
Member

@bryevdv bryevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one question

@mattpap mattpap added status: accepted grant: CZI R5 Funded by CZI Round 5 grant and removed status: ready labels Dec 15, 2023
@mattpap mattpap merged commit 572f7da into branch-3.4 Dec 15, 2023
@mattpap mattpap deleted the mattpap/13507_RangeTool_RangesUpdate branch December 15, 2023 09:45
@mattpap mattpap modified the milestones: 3.4, 3.3.3 Dec 21, 2023
@mattpap mattpap mentioned this pull request Dec 30, 2023
22 tasks
mattpap added a commit that referenced this pull request Jan 8, 2024
* Add a regression test for issue #8890 (#13572)

* Don't register keyup twice in `AutocompleteInput` (#13577)

* Don't register keyup twice in AutocompleteInput

* Pin pytest-asyncio to version 0.21.1

* Link sub-coordinate and context dependent ranges in RangesUpdate (#13603)

* Fix support for global/local imported stylesheets (#13559)

* Compatibility with Chromium 110

* Robustify unit tests involving browser output (#13602)

* Multiple density estimate plot (#13527)

* added sample data

* created density plot

* added gallery images and json

* sorted import order

* clarified plot description

* refactored plotting file

* changed tick formatting style

* deleted unused import

* deleted whitespace

* additional file refactoring

* pyramid example plot (#13596)

* added sample data

* created plot and added plot  description

* added gallery image

* minor edits

* modified plot title

* added bar labels to plot

* removed whitespace

* post-review

* changed color palette

* added plot image

* added extra tick markers

* Remove unnecessary arcTo calls in round_rect (#13627)

* Update license and copyright statements to 2024 (#13630)

* Use `ruff` to ban `typing_extensions` at the top-level (#13633)

* Upgrade to ruff 0.1.11

* Enable TID rules and disable TID252 for now

* Ban `typing_extensions` module at the top-level

* Remove test_no_typing_extensions_common

* Import `typing_extensions` under `TYPE_CHECKING` in `*.pyi`

* Correctly handle transforms in SVG arcTo (#13640)

* ban PIL and other imports with ruff (#13639)

* fix indentation in sphinx extentions (#13549)

* fix indentation in property mixins (#13514)

* fix indentation of default strings with dedent from textwrap

* add missing words in property_mixins.py

* fix indentation in tools.py

* remove dedent block and introduce ALPHA_DEFAULT_HELP and COLOR_DEFAULT_HELP

* change order of imports

* Restored broken API links (#13528)

* restored broken API links

* modified broken API path

* Allow newer tornado and pandas in test-minimal-deps (#13635)

* Add release notes

* Update switcher.json

* avoid_Sphinx ThemeError and set Sphinx to a minimum of 7.1.0 (#13560)

* fix some sphinx warnings (#13609)

* fix some sphinx warnings

* don't make the first line bold

* fix warnings caused by sampledata (#13613)

* add forensic glass and emissions to sampledata.rst (#13615)

---------

Co-authored-by: Azaya <99359668+Azaya89@users.noreply.github.com>
Co-authored-by: Ian Thomas <ianthomas23@gmail.com>
Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com>
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grant: CZI R5 Funded by CZI Round 5 grant status: accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Dispatch RangesUpdate events on all range changes
2 participants