Skip to content

Conversation

@mattpap
Copy link
Contributor

@mattpap mattpap commented Dec 24, 2023

This PR adds support other outline shapes than box/rectangle to Text-like glyphs. Shapes are circumscribed onto the bounding box of text boxes, so that all content fit inside those shapes.

Example (various shapes with Text and TeX glyphs):
image

fixes #8289

@mattpap mattpap added status: WIP grant: SDG 2023 Funded from NumFOCUS Small Development Grant 2023 labels Dec 24, 2023
@mattpap mattpap added this to the 3.4 milestone Dec 24, 2023
@codecov
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (e61219b) to head (83075b3).
Report is 36 commits behind head on branch-3.5.

❗ Current head 83075b3 differs from pull request most recent head 1aa1529. Consider uploading reports for the commit 1aa1529 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-3.5   #13620      +/-   ##
==============================================
+ Coverage       91.57%   92.51%   +0.93%     
==============================================
  Files             326      323       -3     
  Lines           20737    20495     -242     
==============================================
- Hits            18990    18960      -30     
+ Misses           1747     1535     -212     

@ianthomas23
Copy link
Member

This is really nice 😍

@kasra1386
Copy link

this is very good project

@mattpap mattpap modified the milestones: 3.4, 3.5 Feb 28, 2024
@mattpap mattpap changed the base branch from branch-3.4 to branch-3.5 March 14, 2024 16:51
@mattpap mattpap force-pushed the mattpap/8289_text_nodes branch from 83075b3 to 6551749 Compare May 12, 2024 13:01
@mattpap
Copy link
Contributor Author

mattpap commented May 12, 2024

This is tentatively ready. One big missing part of this PR is accurate hit testing, but I think this could be done separately.

@mattpap mattpap force-pushed the mattpap/8289_text_nodes branch from fc6afbe to 1aa1529 Compare May 13, 2024 06:48
@mattpap mattpap merged commit 00c0ade into branch-3.5 May 14, 2024
@mattpap mattpap deleted the mattpap/8289_text_nodes branch May 14, 2024 16:54
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
* Build Text (etc.) glyph's labels once

* Add support for outline shapes to Text glyph

* Add visual integration tests

* Add styling/mathtext/latex_outline_shapes

* Add release notes

* Add a note about hit testing

* Update unit tests

* Rename {plain,trapezium} -> {none,trapezoid}

* Update outline_shape's docstring

* Include outline_shape="none" in tests and examples
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

grant: SDG 2023 Funded from NumFOCUS Small Development Grant 2023 status: accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permanent labels on Networkx graph

5 participants