-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Drop support for Python 3.9 and modernize the codebase #13634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-3.5 #13634 +/- ##
==============================================
+ Coverage 92.59% 92.60% +0.01%
==============================================
Files 326 325 -1
Lines 20735 20732 -3
==============================================
Hits 19199 19199
+ Misses 1536 1533 -3 |
|
This is a nice minpy-bump, as they go. NEP 29 data for dropping Python 3.9 is Apr 05, 2024 so Bokeh 3.5 is probably ideal. |
07eae37 to
e4a9cb4
Compare
Our BEP 9 says it should be at least 3 months after the most recent Python release, which is about now. With pushing this to 3.5 I was thinking about panel. |
|
+1 on waiting until 3.5. That said I would suggest that we amend BEP 9 to align with NEP 29 if they are indeed not synced. I would consider NEP 29 quite aggressive and would not want to be out ahead of them. |
|
@philippjfr we can revisit, but the original rationale for the difference from NEP-29 is here #10558 (comment) It's possible NEP-29 has also been updated since then too. |
e4a9cb4 to
f6dacf0
Compare
|
@mattpap I'd suggest merging this sooner rather than later in order to shave some work off our CI pipeline |
* Drop support for python 3.9
* Use str.remove{prefix,suffix}()
* Replace {typing_extensions->typing}.TypeGuard
* Use `A | B` instead of `Union[A, B]`
* Replace {typing_extensions->typing}.TypeAlias
* Try out pattern matching instead of if-elif-else
* Update dependencies in minimal-deps
* Disable bokeh-docker-test
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR drops support for Python 3.9 and takes advantage of the following PEPs: 634 (pattern matching), 604 (
A | B), 613 (TypeAlias), 647 (TypeGuard). I converted a few obvious cases fromif-elif-elsetomatch-caseas a trial run. I tenatatively added this PR to 3.4 milestone, but I suppose we may want to postpone this till 3.5.fixes #13515