Enable RUF001 to lint confusable characters#13788
Merged
bryevdv merged 1 commit intobokeh:branch-3.5from Apr 1, 2024
Merged
Conversation
Characters which look the same but have different underlying codes (homographs) are problematic. Enable Ruff's "confusable" character linter to prevent new code from accidentally including them. Allow small sigma because of its use in statistics.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.5 #13788 +/- ##
===========================================
Coverage 92.65% 92.65%
===========================================
Files 326 326
Lines 20734 20734
===========================================
Hits 19211 19211
Misses 1523 1523 |
mattpap
added
status: ready
type: task
tag: codebase
bryevdv
approved these changes
Apr 1, 2024
Member
|
Thanks @covracer |
mattpap
pushed a commit
that referenced
this pull request
Apr 10, 2024
Characters which look the same but have different underlying codes (homographs) are problematic. Enable Ruff's "confusable" character linter to prevent new code from accidentally including them. Allow small sigma because of its use in statistics.
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
Characters which look the same but have different underlying codes (homographs) are problematic. Enable Ruff's "confusable" character linter to prevent new code from accidentally including them. Allow small sigma because of its use in statistics.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Characters which look the same but have different underlying codes (homographs) are problematic. Enable Ruff's "confusable" character linter to prevent new code from accidentally including them.
Allow small sigma because of its use in statistics, using the approach suggested by @mattpap #13668 (comment).
ruff .passes