Skip to content

Correctly configure secondary glyphs in GraphRendererView - #13808

Merged
mattpap merged 3 commits into
branch-3.5from
mattpap/13803_GraphRenderer_secondary_glyphs
Apr 7, 2024
Merged

Correctly configure secondary glyphs in GraphRendererView#13808
mattpap merged 3 commits into
branch-3.5from
mattpap/13803_GraphRenderer_secondary_glyphs

Conversation

@mattpap

@mattpap mattpap commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

image

fixes #13803

@codecov

codecov Bot commented Apr 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (44370b1) to head (3413322).

Additional details and impacted files
@@             Coverage Diff             @@
##           branch-3.5   #13808   +/-   ##
===========================================
  Coverage       92.65%   92.65%           
===========================================
  Files             326      326           
  Lines           20734    20736    +2     
===========================================
+ Hits            19211    19213    +2     
  Misses           1523     1523           

@mattpap
mattpap force-pushed the mattpap/13803_GraphRenderer_secondary_glyphs branch from bbdea8f to 3413322 Compare April 5, 2024 19:14
@mattpap
mattpap merged commit 69bddb5 into branch-3.5 Apr 7, 2024
@mattpap
mattpap deleted the mattpap/13803_GraphRenderer_secondary_glyphs branch April 7, 2024 07:50
mattpap added a commit that referenced this pull request Apr 10, 2024
* Correctly configure secondary glyphs in GraphRendererView

* Allow to override properties in HasProps.clone()

* Add regression tests
@mattpap mattpap mentioned this pull request Apr 10, 2024
17 tasks
@mattpap mattpap modified the milestones: 3.5, 3.4.1 Apr 10, 2024
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
)

* Correctly configure secondary glyphs in GraphRendererView

* Allow to override properties in HasProps.clone()

* Add regression tests
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 3.4.0: Selection glyph no longer employs selection_glyph properties

2 participants