Add support for modifiers and allow to auto-activate WheelZoomTool#13815
Merged
mattpap merged 7 commits intobranch-3.5from Apr 10, 2024
Merged
Add support for modifiers and allow to auto-activate WheelZoomTool#13815mattpap merged 7 commits intobranch-3.5from
WheelZoomTool#13815mattpap merged 7 commits intobranch-3.5from
Conversation
Contributor
|
Cool! Can you describe the details of how it "redesigns how tool event handlers are invoked"? |
Contributor
Author
The previous approach using signals didn't allow for returning a value from handlers (like |
bryevdv
approved these changes
Apr 9, 2024
f20a3f7 to
d5ccbf9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.5 #13815 +/- ##
==============================================
+ Coverage 91.57% 92.64% +1.06%
==============================================
Files 326 326
Lines 20737 20751 +14
==============================================
+ Hits 18990 19224 +234
+ Misses 1747 1527 -220 |
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
…okeh#13815) * Allow to indicate if an event was handled by a tool * Allow to configure key modifiers in Wheel*Tool * Allow to auto-activate Wheel*Tool if modifiers are set * Add rudimentary support for plot notifications * Add unit and integration tests * Add release notes * Add concise modifier syntax and improve docstrings
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I started working on scroll support in
BoxAnnotationper issue #13646, but I realized that I need to resolve the more generic issue of conditional handling of scroll events first, so that bokehjs doesn't interfere by with page scrolling, while allowing some way of easy access to scrolling functionality (like wheel zoom or wheel pan tools provide).Thus this PR:
modifierstoWheelZoomToolandWheelPanToolToolbarfor auto-activation of such tools whenmodifiersare setThis example shows
WheelZoomToolconfigured withmodifiers = dict(ctrl=True), first being scrolled without the modifier and then with:Screencast.from.09.04.2024.02.22.41.webm
fixes #10439