fix broken search on the start page #13823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the broken search on the start page of the documentation. The search was broken, because the
search-buttonis searching for a validfrominside a<div></div>. This was missing and because of this, the button raised an error.See the gif below to see how this works on the latest published page.
I also want to quote from https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/search.html:
This is the case on the docs of bokeh. For smaller screens the search button will go to the side bar without any visiable change for the user.
This PR does not solve the JS error with the version banner. The banner is broken for