Robustify bokehjs' SVG unit tests#13843
Merged
mattpap merged 1 commit intobranch-3.5from Apr 28, 2024
Merged
Conversation
bryevdv
approved these changes
Apr 28, 2024
Member
bryevdv
left a comment
bryevdv
left a comment
There was a problem hiding this comment.
I think it is fine to assume that if images are generated by the browser, that they are correct, or at least that testing them is not our responsibility. In which case really all we need to do is make sure that our usage does actually generate images as is now done.
mattpap
added a commit
that referenced
this pull request
Jun 10, 2024
mattpap
added a commit
that referenced
this pull request
Jun 10, 2024
mattpap
added a commit
that referenced
this pull request
Jun 11, 2024
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium produces varying binary PNGs in different versions and on different platforms, so there's no point in comparing such outputs. If we actually rely on verifying generated images, then this should be done in integration tests, where such differences can be accommodated for.