Robustify node make pack and display versions
#13851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
force-pushed
the
mattpap/13848_npm_pack
branch
from
2fb7052 to
34df309
Compare
mattpap
force-pushed
the
mattpap/13848_npm_pack
branch
from
34df309 to
bc2a7e8
Compare
Contributor
Author
|
The problem with |
bryevdv
approved these changes
Apr 29, 2024
mattpap
force-pushed
the
mattpap/13848_npm_pack
branch
from
49e73ad to
dd0e451
Compare
mattpap
added a commit
that referenced
this pull request
Jun 11, 2024
* Robustify `node make pack` and display versions * Upgrade npm in test-setup/action.yml * Lint bokehjs/make/index.js * Use `shell: true` when spawning `npm.cmd` * Add nodejs to downstream environment
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* Robustify `node make pack` and display versions * Upgrade npm in test-setup/action.yml * Lint bokehjs/make/index.js * Use `shell: true` when spawning `npm.cmd` * Add nodejs to downstream environment
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce this on Linux as well, so it was much easier to fix. I also displayed nodejs and npm versions in various relevant outputs (bokehjs' build, extensions compiler, bokeh-ci (previously it was only bokehjs-ci)).
fixes #13848
fixes #13834