-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Restore warning-less sphinx build #13876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Scanning through documentation CI job's logs, there are a few complaints, that perhaps should be addressed in separate PR(s):
(repeats multiple times)
And finally the well known:
|
|
Because the docs for Windows are working again I suggest to add the Line 41 in f5e07a3
|
|
Some of those are from testing deprecated APIs, so they make sense to be there and will go away when the deprecated APIs go away (speaking of, I think we could drop the tile provider one at this point?) I'll try to look at the other in another PR. |
* fix sphing warnings * update make.bat too
* fix sphing warnings * update make.bat too
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR fixes all outstanding sphinx warnings, and also restores the
-Wpassed tosphinx-buildto enforce no-warnings.@tcmetzger I had to get rid of the
**glob and make thehtml_sidebarsconfig slightly more explicit. Unfortunately I don't think there is any way to avoid this, given the limitations of glob syntax. But there's only a handful of directories and our docs structure does not change often.I also made some of the
sphinxextextensions much more informative, e.g. by changing"<bokeh-prop>"tof"<bokeh-prop: {model_name}.{prop_name}>". I am not sure why it took me 10+ years to realize that was an option...@mattpap I put in minimal docstrings for
bokeh buildandbokeh initcommand. I think these can/should be expanded but I don't intend to do that in this PR.