Implement data inheritance in ImageBase._set_data()#13952
Merged
mattpap merged 3 commits intobranch-3.5from Jun 27, 2024
Merged
Implement data inheritance in ImageBase._set_data()#13952mattpap merged 3 commits intobranch-3.5from
ImageBase._set_data()#13952mattpap merged 3 commits intobranch-3.5from
Conversation
philippjfr
approved these changes
Jun 27, 2024
Contributor
philippjfr
left a comment
philippjfr
left a comment
There was a problem hiding this comment.
Looks great, thank you!
Member
|
I would be +1 to release a 3.4.3 with this fix |
mattpap
added a commit
that referenced
this pull request
Jun 27, 2024
* Implement data inheritance in ImageBase._set_data()
* Rename {_width,_height} -> image_{width,height}
* Add unit regression tests
mattpap
added a commit
that referenced
this pull request
Jul 24, 2024
* Implement data inheritance in ImageBase._set_data()
* Rename {_width,_height} -> image_{width,height}
* Add unit regression tests
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* Implement data inheritance in ImageBase._set_data()
* Rename {_width,_height} -> image_{width,height}
* Add unit regression tests
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements data inheritance in
Image-like glyphs (Image,ImageRGBAandImageStack). This was overlooked in PR #13554 and any previous follow-ups to that PR.I suppose this could be backported to 3.4, though 3.4.2 was just released, so we would have to do that as a part of 3.4.3.
fixes #13951