Add size to Scatter

[mosc9575]

This PR fixes the explicit selection glyph example by adding size parameter to the Scatter model, which is by default 4.

• issues: fixes Explicit selection glyph example broken #13957

Here the result with the fix using bokeh 3.4.2 in a jupyter notebook after a click.

[bryevdv]

I think the best solution here is for the scatter sub-glyphs to inherit size by default if the user does not override it explicitly. I.e. it should be possible but not required to override the main glyph value, for sub-glyphs. That's how other properties work for sub-glyphs.

[mosc9575]

I tried to solve the problem and updated the javascript code to inherit from the base glyph.

For the example the visual output meets my expectations.

from bokeh.models import Scatter, Circle, ColumnDataSource
from bokeh.resources import Resources
from bokeh.plotting import figure, show, output_notebook

source = ColumnDataSource(dict(xx=[1, 2, 3, 4, 5],yy=[2, 5, 8, 2, 7]))

plot = figure(width=400, height=400, tools="tap", title="Select a circle")
renderer = plot.scatter('xx', 'yy', size=50, source=source)

selected_scatter = Circle(fill_alpha=1, fill_color="firebrick", radius=0.1)
nonselected_scatter = Scatter(fill_alpha=0.2, fill_color="blue", line_color="firebrick")

renderer.selection_glyph = selected_scatter
renderer.nonselection_glyph = nonselected_scatter

show(plot)

The problem is, that the models on the Python side are not updated and I don't know how I can solve this.

@bryevdv and @mattpap Help is needed. Any suggestions on the code and how to solve this for python are welcome. I will try finish this PR afterwards.

[bryevdv]

@mosc9575 thanks for your patience, please take a look at #13957 (comment) for what I think is a better short-term "python only" solution that does not burden the user with manually keeping properties in sync, and does not burden us with technical lifts.

To fully implement this, we'll want to search and update all examples that set sub-glyphs using the bokeh.models API to follow that pattern with clone. Please let me know whether you have the bandwidth continue with these updates here. I understand, if not, but then I will close this PR.

[mosc9575]

@bryevdv I will try to do this task in the next few days.

[mosc9575]

While working on some examples I also fixed some PEP-Warnings and had to rearange some lines for the code style checks. This is why some files have "many" changes.

[mattpap]

It would nice if we could enable the same style of imports, that we use under src/, for when we need to import a lot of models, etc.

[mosc9575]

If I change the style of the imports the pre-push-hook test_isort fails.

We could add -m=3 to the line below

bokeh/tests/codebase/test_isort.py

Line 58 in df57080

proc = run(["isort", "--gitignore", "--diff", "-c", dir], capture_output=True)

but this woul mean, we have to change all import in all files. This would be worth a new issue. Is it okey for you if I open a seperate PR, to make this change to all import in this project?

[bryevdv]

The import style under examples was made different from that under src on purpose. We can discuss whether that should be the case or not any longer, but we should not take any action regarding that in this PR. In any was there should be an issue to discuss and decide the course of action first.

[mosc9575]

With this change and adding the "TapTool" to the tools, this example makes more sense to me. In the newer version a click on a renderer has a visual effect.

[mosc9575]

The consecutive "will" is fixed, but this fix is unrelated to the original issue.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.