Remove Step 7 (download sample data) from setup docs #13962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.6 #13962 +/- ##
=============================================
Coverage ? 93.10%
=============================================
Files ? 280
Lines ? 19799
Branches ? 0
=============================================
Hits ? 18433
Misses ? 1366
Partials ? 0 |
mattpap
requested changes
Jul 4, 2024
Chiemezuo
force-pushed
the
13960_remove_download_sampledata
branch
from
a5298dd to
a566609
Compare
Member
|
@Chiemezuo looks good, did you also want to remove second location as you suggested n #13960 (comment) ? |
Contributor
Author
|
@bryevdv I forgot to do that, but I've done it now. |
mattpap
approved these changes
Jul 11, 2024
Contributor
|
@Chiemezuo, thanks. |
Contributor
Author
|
The pleasure is all mine @mattpap |
Chiemezuo
added a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* remove download sampledata from setup docs * add install guide to bokeh_sampledata init * remove install bokeh_sampledata in writing docs doc
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #13960.
As @pavithraes mentioned, since Sample data was moved to a package that gets installed with the environment setup, it's no longer necessary in the setup guide, and can be a bit misleading if left as is.