Always proxy tools (even if only one) when merging toolbars #13978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
approved these changes
Jul 12, 2024
mattpap
added a commit
that referenced
this pull request
Jul 12, 2024
mattpap
added a commit
that referenced
this pull request
Jul 13, 2024
mattpap
added a commit
that referenced
this pull request
Jul 24, 2024
mattpap
added a commit
that referenced
this pull request
Jul 25, 2024
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise two
ResetToolViewinstances are built for a singleResetToolmodel, one for the plot and one for the grid plot. Grid plot doesn't supportreset()method, so things fail, and even if it did, then the work would be duplicated. So nowToolProxyis created in all cases.fixes #13959