Fix ValueError in get_graph_kwargs

[cdeil]

This PR fixes the warning I see in PyCharm static code analysis:

Unresolved attribute reference 'message' for class 'ValueError'

This seems to work:

In [6]: import sys

In [7]: node_source = "my node source"

In [8]: try:
   ...:     raise ValueError("spam alot")
   ...: except ValueError as err:
   ...:     msg = f"Failed to auto-convert {type(node_source)} to ColumnDataSource.\n Original error: {err.message}"
   ...:     raise ValueError(msg).with_traceback(sys.exc_info()[2])
   ...: 
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[8], line 2
      1 try:
----> 2     raise ValueError("spam alot")
      3 except ValueError as err:

ValueError: spam alot

During handling of the above exception, another exception occurred:

AttributeError                            Traceback (most recent call last)
Cell In[8], line 4
      2     raise ValueError("spam alot")
      3 except ValueError as err:
----> 4     msg = f"Failed to auto-convert {type(node_source)} to ColumnDataSource.\n Original error: {err.message}"
      5     raise ValueError(msg).with_traceback(sys.exc_info()[2])

AttributeError: 'ValueError' object has no attribute 'message'

In [9]: try:
   ...:     raise ValueError("spam alot")
   ...: except ValueError as err:
   ...:     msg = f"Failed to auto-convert {type(node_source)} to ColumnDataSource.\n Original error: {err}"
   ...:     raise ValueError(msg).with_traceback(sys.exc_info()[2])
   ...: 
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[9], line 2
      1 try:
----> 2     raise ValueError("spam alot")
      3 except ValueError as err:

ValueError: spam alot

During handling of the above exception, another exception occurred:

ValueError                                Traceback (most recent call last)
Cell In[9], line 5
      3 except ValueError as err:
      4     msg = f"Failed to auto-convert {type(node_source)} to ColumnDataSource.\n Original error: {err}"
----> 5     raise ValueError(msg).with_traceback(sys.exc_info()[2])

Cell In[9], line 2
      1 try:
----> 2     raise ValueError("spam alot")
      3 except ValueError as err:
      4     msg = f"Failed to auto-convert {type(node_source)} to ColumnDataSource.\n Original error: {err}"

ValueError: Failed to auto-convert <class 'str'> to ColumnDataSource.
 Original error: spam alot

Is it really useful to catch a ValueError and raise another?
Apply this fix here or instead remove the whole try/except?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (branch-3.6@5aecc61). Learn more about missing BASE report.

Additional details and impacted files

@@              Coverage Diff              @@
##             branch-3.6   #14022   +/-   ##
=============================================
  Coverage              ?   93.16%           
=============================================
  Files                 ?      282           
  Lines                 ?    19850           
  Branches              ?        0           
=============================================
  Hits                  ?    18494           
  Misses                ?     1356           
  Partials              ?        0           

[bryevdv]

Is it really useful to catch a ValueError and raise another?

The value is in providing a more tailored exception message with more information for the user.

Similar to the other PR it would be good to add some tests for these codepaths since evidently they were missing.

[cdeil]

Added a test: 079b336

[bryevdv]

Thanks @cdeil !

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.