Allow values of any type in GroupFilter.group#14034
Merged
Merged
Conversation
Member
|
The docsctring for
since the usage is no longer confined to categorical columns |
bryevdv
approved these changes
Aug 21, 2024
Member
bryevdv
left a comment
bryevdv
left a comment
There was a problem hiding this comment.
Just one comment about the docstring update
Also switches from using === for value equality to is_equals(), which allows handling of NaN, arrays and other complex types.
mattpap
force-pushed
the
mattpap/7524_GroupFilter_value_type
branch
from
8caf2c9 to
a3f28fb
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also switches from using
===for value equality tois_equals(), which allows handling of NaN, arrays and other complex or unusual types. Performance hit should be minimal for primitives, becauseis_equal()has hot paths for these. In the future, this will also allow us to implement inexact equality for floats.fixes #7524