Conversation
bryevdv
commented
Sep 4, 2024
bryevdv
commented
Sep 4, 2024
bryevdv
commented
Sep 4, 2024
bryevdv
commented
Sep 4, 2024
mattpap
reviewed
Sep 4, 2024
mattpap
reviewed
Sep 4, 2024
mattpap
reviewed
Sep 4, 2024
mattpap
reviewed
Sep 4, 2024
Contributor
There aren't many tests for this, but there is one recently added that should be quite useful as a basis: bokeh/bokehjs/test/unit/regressions.ts Lines 663 to 692 in 78dcbf3 |
mattpap
reviewed
Sep 4, 2024
961879a to
dfe24b1
Compare
mattpap
reviewed
Sep 16, 2024
mattpap
reviewed
Sep 16, 2024
mattpap
reviewed
Sep 16, 2024
Member
Author
|
@mattpap it looks like you've addressed all your own comments? |
Contributor
Yes, given that they were all related to the same code block. |
mattpap
approved these changes
Sep 17, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for an
AxisClick/"axis_click"event that reports the location that an axis was clicked.This can be tested by adding code like the following to nearly any example":
This needs some polish: