Allow to update GridPlot.children
#14070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
approved these changes
Sep 20, 2024
mattpap
force-pushed
the
mattpap/14068_update_GridPlot.children
branch
from
edbeac9 to
a314591
Compare
mattpap
commented
Sep 20, 2024
| } | ||
|
|
||
| setv(changed_attrs: Attrs, options: HasProps.SetOptions = {}): void { | ||
| setv<T extends Attrs>(changed_attrs: Partial<T>, options: HasProps.SetOptions = {}): void { |
Contributor
Author
There was a problem hiding this comment.
In theory it should be possible to infer T from typeof this["properties"], but that works in some contexts, but not in all. When it doesn't work, then T == any and we get a dynamically typed API with no warning.
Member
There was a problem hiding this comment.
I think this would be an unacceptable burden if end-users were required to specify the type but as setv is really internal API, practically speaking, we can just deal with it.
mattpap
force-pushed
the
mattpap/14068_update_GridPlot.children
branch
from
a314591 to
f83958f
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14068