RadialGlyph should inherit from XYGlyph#14085
Merged
bryevdv merged 2 commits intobranch-3.7from Sep 28, 2024
Merged
Conversation
bryevdv
force-pushed
the
bv/14082-xy-glyph-hierarchy
branch
from
58084a2 to
89dd8eb
Compare
mattpap
reviewed
Sep 27, 2024
| @@ -55,19 +55,27 @@ | |||
|
|
|||
| # Module under test | |||
| from bokeh.models.glyphs import ( # isort:skip | |||
Contributor
There was a problem hiding this comment.
Given the changes, then this can be removed now:
Suggested change
| from bokeh.models.glyphs import ( # isort:skip | |
| from bokeh.models.glyphs import ( |
mattpap
approved these changes
Sep 27, 2024
mattpap
pushed a commit
that referenced
this pull request
Dec 2, 2024
* RadialGlyph should inherit from XYGlyph * imports
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was just a pure oversight or typo —
RadialGlyphshould inherit fromXYGlyphregardless of where properties are defined.