Skip to content

Allow CrosshairTool and HoverTool to trigger from axes#14124

Merged
mattpap merged 3 commits intobranch-3.7from
mattpap/14122_CrosshairTool_on_axes
Oct 29, 2024
Merged

Allow CrosshairTool and HoverTool to trigger from axes#14124
mattpap merged 3 commits intobranch-3.7from
mattpap/14122_CrosshairTool_on_axes

Conversation

@mattpap
Copy link
Copy Markdown
Contributor

@mattpap mattpap commented Oct 25, 2024

Screencast.from.2024-10-26.01-04-07.webm

fixes #14122

@mattpap mattpap added this to the 3.7 milestone Oct 25, 2024
@mattpap mattpap force-pushed the mattpap/14122_CrosshairTool_on_axes branch from 3263821 to c9ac8a5 Compare October 26, 2024 08:40
@mattpap mattpap changed the title Allow CrosshairTool to work on axes Allow CrosshairTool and HoverTool to work on axes Oct 26, 2024
@mattpap
Copy link
Copy Markdown
Contributor Author

mattpap commented Oct 27, 2024

I added similar support to HoverTool:

Screencast.from.2024-10-26.10-40-53.webm

@mattpap mattpap force-pushed the mattpap/14122_CrosshairTool_on_axes branch from 789f48b to c4a1ecb Compare October 28, 2024 21:26
Copy link
Copy Markdown
Member

@bryevdv bryevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments

Comment thread docs/bokeh/source/docs/releases/3.7.0.rst Outdated
Comment thread bokehjs/src/lib/models/tools/inspectors/crosshair_tool.ts Outdated
@mattpap mattpap force-pushed the mattpap/14122_CrosshairTool_on_axes branch from c4a1ecb to 6f27fc6 Compare October 29, 2024 08:59
@mattpap mattpap changed the title Allow CrosshairTool and HoverTool to work on axes Allow CrosshairTool and HoverTool to trigger from axes Oct 29, 2024
@mattpap mattpap force-pushed the mattpap/14122_CrosshairTool_on_axes branch from 6f27fc6 to 58761ab Compare October 29, 2024 09:00
@mattpap mattpap force-pushed the mattpap/14122_CrosshairTool_on_axes branch from 58761ab to 749db65 Compare October 29, 2024 09:17
@mattpap
Copy link
Copy Markdown
Contributor Author

mattpap commented Oct 29, 2024

Test failures are unrelated and reported in #14128.

@mattpap mattpap merged commit fbbb011 into branch-3.7 Oct 29, 2024
@mattpap mattpap deleted the mattpap/14122_CrosshairTool_on_axes branch October 29, 2024 16:16
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow CrosshairTool to work on axes

2 participants