Add support for stateful action tools#14143
Merged
Merged
Conversation
mattpap
force-pushed
the
mattpap/13773_togglable_action_tool
branch
from
November 11, 2024 10:28
b9e6184 to
30ce72e
Compare
mattpap
force-pushed
the
mattpap/13773_togglable_action_tool
branch
2 times, most recently
from
December 4, 2024 07:16
98ddc95 to
255496b
Compare
hoxbro
reviewed
Dec 4, 2024
hoxbro
approved these changes
Dec 6, 2024
hoxbro
left a comment
hoxbro
left a comment
Contributor
There was a problem hiding this comment.
One thing I don't completely understand. But other than that, this LGTM.
mattpap
force-pushed
the
mattpap/13773_togglable_action_tool
branch
from
December 16, 2024 14:15
27efd53 to
5c8b265
Compare
Contributor
Author
|
The problem with testing was only partially due to readiness notification. Mostly it was due to unreliable tapping gesture, which sometimes didn't trigger, maybe do to page scrolling or something related. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example in the case of
ExamineTool:Screencast.from.2024-11-07.13-04-33.webm
Using
CustomAction(fromexamples/interaction/tools/legend_visibility_tool.py):Screencast.from.2024-11-07.13-06-42.webm
fixes #13773
fixes #14183