Make Toolbar respect Tool visibility#14251
Merged
Merged
Conversation
mattpap
force-pushed
the
mattpap/14246_tool_visible
branch
from
1823450 to
a3c90a8
Compare
mattpap
commented
Jan 27, 2025
mattpap
force-pushed
the
mattpap/14246_tool_visible
branch
from
a3c90a8 to
0a432ab
Compare
mattpap
force-pushed
the
mattpap/14246_tool_visible
branch
from
0a432ab to
4e7417c
Compare
mattpap
force-pushed
the
mattpap/14246_tool_visible
branch
from
a2ea05e to
609744f
Compare
Contributor
Author
|
This is now fully ready. |
bryevdv
approved these changes
Feb 13, 2025
bryevdv
left a comment
bryevdv
left a comment
Member
There was a problem hiding this comment.
Seems ok from a glance at the tests.
RamiDarwiche
pushed a commit
to RamiDarwiche/bokeh
that referenced
this pull request
Feb 23, 2025
* Make Toolbar respect Tool visibility * Add release notes * Update toolbar's unit tests * Update ToolButton bbox in Toolbar.after_render() * Update visual baselines * Add regression tests
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14246