Skip to content

Add support for label and on/off icons to Switch widget - #14294

Merged
mattpap merged 6 commits into
branch-3.7from
mattpap/14292_switch
Feb 8, 2025
Merged

Add support for label and on/off icons to Switch widget#14294
mattpap merged 6 commits into
branch-3.7from
mattpap/14292_switch

Conversation

@mattpap

@mattpap mattpap commented Feb 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
Screencast.from.2025-02-07.23-11-49.webm

fixes #14292

@mattpap mattpap added this to the 3.7 milestone Feb 7, 2025
@bryevdv

bryevdv commented Feb 7, 2025

Copy link
Copy Markdown
Member

Aren't a lot of color mode pickers trivariate (light/dark/system)? See e.g. the color mode button at the top of the pd sphinx theme: https://pydata-sphinx-theme.readthedocs.io/en/stable/ Regardless, after some quick searching I do think a "sun" is common for light mode but something like a "crescent moon" is more common for dark mode.

@mattpap
mattpap force-pushed the mattpap/14292_switch branch from 8325940 to cddf436 Compare February 8, 2025 00:00
@mattpap
mattpap force-pushed the mattpap/14292_switch branch from cddf436 to d291a4e Compare February 8, 2025 00:28
@mattpap
mattpap force-pushed the mattpap/14292_switch branch from d291a4e to e2b2c08 Compare February 8, 2025 00:30
bryevdv
bryevdv approved these changes Feb 8, 2025
View reviewed changes

@bryevdv bryevdv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM my only suggestion is to proactively add a system_theme icon as well, for anyone that wants to implement a tri-state theme button

@mattpap

mattpap commented Feb 8, 2025

Copy link
Copy Markdown
Contributor Author

my only suggestion is to proactively add a system_theme icon as well, for anyone that wants to implement a tri-state theme button

Work will continue on this in issue #14220.

@mattpap
mattpap merged commit 31c064b into branch-3.7 Feb 8, 2025
@mattpap
mattpap deleted the mattpap/14292_switch branch February 8, 2025 08:13
@github-actions

github-actions Bot commented May 21, 2025

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryevdv bryevdv bryevdv approved these changes

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

3.7

Development

Successfully merging this pull request may close these issues.

Add label and on/off icon to Switch widget

2 participants

@mattpap @bryevdv