Implement hatch visuals consistently with fill visuals#14311
Merged
Conversation
mattpap
commented
Feb 11, 2025
mattpap
commented
Feb 11, 2025
| # Bokeh imports | ||
| from ..._types import CoordinateLike, NullStringSpec, TextLike | ||
| from ..._specs import NullStringSpec | ||
| from ..._types import CoordinateLike, TextLike |
Contributor
Author
There was a problem hiding this comment.
This and other cases weren't found in the original PR, because we skip type-checking in many modules, which also makes mypy skip checking associated *.pyi files (at least that's my understanding).
mattpap
force-pushed
the
mattpap/14310_fill_hatch
branch
4 times, most recently
from
459eb31 to
bc24e2b
Compare
bryevdv
approved these changes
Feb 12, 2025
mattpap
force-pushed
the
mattpap/14310_fill_hatch
branch
from
bc24e2b to
ae24bce
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14310