display color as hex string in color_sliders.py#14395
Conversation
|
I suppose this is fine but personally I preferred seeing the hex color codes, also that's what's in the gallery thumbnail. If there is any easy way to fix this in that other direction, I think that is preferable. (I was not clear in the issue, but the tuple showing up initially is the new and different change, i.e. the "bug". Previously it always showed a hex code, even initially) |
|
|
||
| # create a data source to enable refreshing of fill & text color | ||
| source = ColumnDataSource(data=dict(color=[color], text_color=[text_color])) | ||
| source = ColumnDataSource(data=dict(color=[color], color_string=[color], text_color=[text_color])) |
There was a problem hiding this comment.
I must be missing something, but where color_string is consumed?
|
I will push an update which will start with a hex string and does not introduce
|
There was no good reason except to keep the change minimal. To be consistent I changed the |
mosc9575
changed the title
mattpap
deleted the
14393_fix_inconsistent_lableling_in_color_slider_example
branch
* add color_string to show rgb as sting in color_sliders.py * show hex instead of rgb * simplify * start with hex color for text_color
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
The change results in showing color as RGB.
@bryevdv Do you think it is a good idea to show color as rbg and hex? If not this is fixed and can be marked as ready.