Skip to content

optimize unique calculation#14421

Merged
bryevdv merged 2 commits intobokeh:branch-3.8from
muendlein:enhance_performance_multi_marker_webgl
Mar 24, 2025
Merged

optimize unique calculation#14421
bryevdv merged 2 commits intobokeh:branch-3.8from
muendlein:enhance_performance_multi_marker_webgl

Conversation

@muendlein
Copy link
Copy Markdown
Contributor

@muendlein muendlein commented Mar 15, 2025

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (branch-3.8@3809c69). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             branch-3.8   #14421   +/-   ##
=============================================
  Coverage              ?   93.25%           
=============================================
  Files                 ?      284           
  Lines                 ?    20141           
  Branches              ?        0           
=============================================
  Hits                  ?    18783           
  Misses                ?     1358           
  Partials              ?        0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattpap mattpap added this to the 3.8 milestone Mar 16, 2025
Copy link
Copy Markdown
Member

@ianthomas23 ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @muendlein

@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Mar 24, 2025

@muendlein are you waiting on something to merge this? I think it could be included in a 3.7.1. back port but it would need to be merged ASAP

@muendlein
Copy link
Copy Markdown
Contributor Author

@bryevdv I'm just waiting for it to be merged 😄

@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Mar 24, 2025

@muendlein our process is normally "self-merge after approval" for folks in @bokeh/dev which I had thought included you. Would you like to be added?

@bryevdv bryevdv merged commit 20132e6 into bokeh:branch-3.8 Mar 24, 2025
26 checks passed
@bryevdv bryevdv mentioned this pull request Mar 24, 2025
10 tasks
mattpap pushed a commit that referenced this pull request Mar 25, 2025
* optimize unique calculation

* fix bracket
@muendlein
Copy link
Copy Markdown
Contributor Author

@bryevdv Feel free to add me to me! At least until now I have not been aware of it.

@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Mar 25, 2025

@muendlein you should now have received an invitation to join @bokeh/dev. Apologies I thought you were already added or I would have asked you about it much earlier. Just re-iterating the process above: after joining, please feel free to self-merge your own PRs once you have at least one approval and CI is green!

@mattpap mattpap modified the milestones: 3.8, 3.7.1 Mar 25, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 9, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance performance of WebGL multi_marker

4 participants