Fix Legend's inactive visuals in CSS mode#14454
Merged
Merged
Conversation
hoxbro
approved these changes
Apr 10, 2025
hoxbro
left a comment
hoxbro
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
In the issue, you wrote:
In 3.7 there's partial support for selectable text on the canvas, thus the cursor. We may introduce a mode for toggling text selectablity in the future.
Have you opened an issue/discussion about this?
| new LegendItem({label: "3*sin(x)", renderers: [r3, r4]}), | ||
| ], | ||
| location: "top_right", | ||
| click_policy: "mute", |
Contributor
There was a problem hiding this comment.
Maybe have a parameterized test, where click_policy has mute and hide.
Not sure if the BokehJS test framework can easily do this; if it can't, then just ignore this.
Contributor
Author
There was a problem hiding this comment.
Not sure if the BokehJS test framework can easily do this; if it can't, then just ignore this.
Typically we would add a function with a single argument for this.
Maybe have a parameterized test, where click_policy has mute and hide.
Visual behavior is the same for all interactive policies.
Contributor
Author
|
hoxbro
approved these changes
Apr 10, 2025
mattpap
added a commit
that referenced
this pull request
Apr 10, 2025
* Fix Legend's inactive visuals in CSS mode * Add visual regression tests
mattpap
added a commit
that referenced
this pull request
Apr 24, 2025
* Fix Legend's inactive visuals in CSS mode * Add visual regression tests
mattpap
added a commit
that referenced
this pull request
May 8, 2025
* Update switcher.json * Fix Legend's glyph rendering for `dpr != 1` (#14443) * Fix Legend's glyph rendering for dpr != 1 * Allow to override screen scaling in testing * Add regression tests * Fix Legend's inactive visuals in CSS mode (#14454) * Fix Legend's inactive visuals in CSS mode * Add visual regression tests * Update child views without removing their elements (#14459) * Implement LayoutDOM.update_children without explicitly removing nodes * Fix lint * Fix logic * More lint * Simplify for loop * No tabs * Also update handling of element views * Remove empty line * Fix self_target children lookup * Fix type errors * Fix and simplify logic * Fix element views * Apply suggestions from code review * Simplify further * Fix lint * Revert to append (instead of appendChild) Rever * Compare DOM nodes non-structurally by identity * Add regression tests * Unify all rebuilding of child views --------- Co-authored-by: Mateusz Paprocki <mattpap@gmail.com> * update docs for DatetimeTickFormatter (#14452) * Updated formatters.py --------- Co-authored-by: Chinmay <chinmay.cc.06@gmail.com> * fix links to code pen (#14471) * add jquery to fix links to code pen * remove jquery dependency * remove patched show function * use Node.COMMENT_NODE instead of number * avoid line breaks in templates and code pen * fix missing title * Fix positioning of DOM rendered Legend annotations (#14457) * Fix positioning of DOM rendered Legend annotations * Treat inner canvas panels equally to outer * Robustify resize of canvas after layout * Update visual baselines * Make sticky toolbar work correctly * Refactor PlotView._update_layout() * Invalidate layout if renderers change * Add more regression tests * Update visual baselines * Always repaint Legend's glyphs after rendering * Update visual baselines * Implement move semantics in Plot.add_layout() * Tighten regressions' baseline viewports * Fix types of splattable figure's attributes (#14401) * Fix types of splattable figure's attributes * Add rudimentary typing tests * Python 3.10 compatibility * Improve corner case handling in datetime formatter (#14473) * Add release notes --------- Co-authored-by: Philipp Rudiger <prudiger@anaconda.com> Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> Co-authored-by: Chinmay <chinmay.cc.06@gmail.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14442