Add support for side panel layouts and SizeBar annotation - #14487
Conversation
c1828af to
a88513a
Compare
a88513a to
9709d81
Compare
SizeBar annotation
|
TODO:
|
9709d81 to
5b0fd30
Compare
|
Is this nearly ready for review? |
|
@droumis, it's pretty close. I will make it reviewable by Monday. |
5b0fd30 to
a79c46d
Compare
philippjfr
left a comment
There was a problem hiding this comment.
The implementation looks fine to me. Main comment I have is about the missing documentation.
a79c46d to
8d296d3
Compare
|
This is tentatively ready. I'm still polishing some rough edges though. |
ebce5a6 to
e7a48c2
Compare
53311f3 to
364cb99
Compare
364cb99 to
a76a4a8
Compare
|
I pushed some doc improvements. I also tried running the example in Dependencies |
Either you didn't build bokehjs correctly or incorrect version of bokehjs is being used by the example (e.g. you will need to run examples under devtools with caching disabled). For now I can refer you to https://docs.bokeh.org/en/latest/docs/dev_guide/setup.html, be we can also set up a session to go through bokeh's dev setup. |
I used a fresh set-up before running the example and I've tried disabling cache in the browser but still a blank page. I'm open to setting up a session to go through my setup. Maybe I'm missing something... |
682d4e7 to
2185959
Compare
hoxbro
left a comment
There was a problem hiding this comment.
I have left some comments.
I have a big concern, which is that the sizebar is only valid in the initial rendering; if I zoom in/out, the size does not update to match the actual size in the plot.
I'm also not sure how it would work when you set a radius_dimension=min on the circle glyph, and the axes are different scales. Though I haven't given it a go yet.
A smaller concern is, I actually want to have a border around the size bar, but I don't think it is a blocker.
Some bugs I also discovered when playing around with it:
- If you zoom in on the webpage, the sizebar disappears:
Screencast.From.2025-08-11.11-44-29.mp4
- It is not shown when saving the plot:
I'm working on this, though a solution causes other issues. |
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
a003d31 to
21a2978
Compare
I'm talking about these lines, which, as I read them, will not respect the user input, e.g., if bokeh/bokehjs/src/lib/models/annotations/size_bar.ts Lines 301 to 302 in 7764ae1
Not the most elegant way to do it, but OK.
Can you open an issue for this? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is a very preliminary implementation of generic layouts in
Plot's side and center panels. This will also allow to support layouts of annotations (Legend,ColorBar). This is a prerequisite for resolving issue #2603. This will eventually allow to simplifyColorBar's implementation.Screencast.from.2025-05-14.15-40-57.webm
Code
Plot's side and center panels #14323