Skip to content

Replace more PNG icons with SVGs - #14518

Merged
pavithraes merged 4 commits into
branch-3.8from
pavithraes/12282-more-svg-icons
Jun 6, 2025
Merged

Replace more PNG icons with SVGs#14518
pavithraes merged 4 commits into
branch-3.8from
pavithraes/12282-more-svg-icons

Conversation

@pavithraes

@pavithraes pavithraes commented Jun 4, 2025

Copy link
Copy Markdown
Member

General todos:

PR-specific todos:

  • Update ToggleMode icon
  • Update baseline tests

Notes:

  • The new icons were exported from Figma and have colors associated with them, but I think the CSS mask will override it and that is what we want for consistency.
  • Need to add @smeragoel as co-author on the PR, as the design contributor for new icons
  • Icons in documentation still use old png versions, updating these is a little more involved, so I think we can do that in a separate PR: [DOCS] Update docs pages with new SVG icons #14521

@pavithraes
pavithraes marked this pull request as ready for review June 6, 2025 11:45
@mattpap mattpap added this to the 3.8 milestone Jun 6, 2025
@pavithraes
pavithraes merged commit 3801f1d into branch-3.8 Jun 6, 2025
@mattpap
mattpap deleted the pavithraes/12282-more-svg-icons branch June 6, 2025 12:44
@mosc9575

mosc9575 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Sorry for the late review, but since the ToggleMode icon is updated, I think the lines

.tool-icon(@icon, @file) {
@path: "../../../docs/bokeh/source/_images/icons";
background-image: var(@icon, data-uri("@{path}/@{file}.png"));
}

arn't needed anymore. If I am right, they should be deleted to avoid an unnecessary fragment.

@mattpap

mattpap commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

There's more cleanup needed elsewhere as well, that's why I didn't push for doing it in this PR.

@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalize migration from PNG to SVG icons

3 participants