Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move palettes in bokehjs to bokeh-api bundle #5183

Merged
merged 5 commits into from Sep 19, 2016
Merged

Conversation

@mattpap
Copy link
Contributor

@mattpap mattpap commented Sep 19, 2016

fixes #5182

@@ -113,7 +115,7 @@ class Image extends Glyph.Model
dw: [ p.DistanceSpec ]
dh: [ p.DistanceSpec ]
dilate: [ p.Bool, false ]
color_mapper: [ p.Instance, () -> new LinearColorMapper.Model(palette: Greys.Greys9) ]
color_mapper: [ p.Instance, () -> new LinearColorMapper.Model({palette: Greys9()}) ]

This comment has been minimized.

@mattpap

mattpap Sep 19, 2016
Author Contributor

This was a minor hiccup.

"js/bokeh-api.min.js": 40
"js/bokeh.min.js": 918
"js/bokeh-api.min.js": 70
"js/bokeh.min.js": 780

This comment has been minimized.

@mattpap

mattpap Sep 19, 2016
Author Contributor

Currently bokeh.min.js is at 757 kB and I'm still working on webgl split-off, which will result in at least -60 kB.

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Sep 19, 2016

LGTM

@bryevdv bryevdv merged commit c6bd829 into master Sep 19, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bryevdv bryevdv deleted the mattpap/5182_api_palettes branch Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.