Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up common/ and util/ #5266

Merged
merged 13 commits into from Oct 4, 2016
Merged

Clean up common/ and util/ #5266

merged 13 commits into from Oct 4, 2016

Conversation

@mattpap
Copy link
Contributor

@mattpap mattpap commented Oct 3, 2016

This is based on PR #5265. There is get_indices() in utils/ left, because I wasn't sure what to do with it.

fixes #5263

@mattpap mattpap mentioned this pull request Oct 4, 2016
0 of 3 tasks complete
@bryevdv bryevdv added the MIGRATION label Oct 4, 2016
@bryevdv
Copy link
Member

@bryevdv bryevdv commented Oct 4, 2016

Added MIGRATION There are probably some people using common/hittest.coffee

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Oct 4, 2016

There is get_indices() in utils/ left, because I wasn't sure what to do with it.

Can't it just go wherever, in core/util ?

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Oct 4, 2016

Or maybe it could be a method on column data source until sections get improved. I don't want to go through all this and still leave one thing hanging in common, though.

@mattpap
Copy link
Contributor Author

@mattpap mattpap commented Oct 4, 2016

Can't it just go wherever, in core/util ?

It can, it just I was hoping to remove it entirely (well replace), because it doesn't the current approach doesn't make sense. btw. common/ is gone completely by now and we are talking about top-level util/.

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Oct 4, 2016

Sure, let's get rid of top level util too. Agreed it does not make much sense, but there is another entire issue to improve selections. It needs some thought and design up front, so for now this could just be moved.

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Oct 4, 2016

LGTM

@bryevdv bryevdv merged commit 5ff5fd3 into master Oct 4, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bryevdv bryevdv deleted the mattpap/5263_common_core branch Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.