Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #5274

Merged
merged 2 commits into from Oct 4, 2016
Merged

Fix deprecation warnings #5274

merged 2 commits into from Oct 4, 2016

Conversation

@mattpap
Copy link
Contributor

@mattpap mattpap commented Oct 3, 2016

@bokeh/dev, please join and help out as time permits.

TODO:

  • text_font_size="10pt" -> text_font_size=value("10pt")
  • plot.title = "title" -> plot.title.text = "title"

fixes #5273

@mattpap mattpap added the status: WIP label Oct 3, 2016
@bryevdv
Copy link
Member

@bryevdv bryevdv commented Oct 3, 2016

@mattpap well, as I mentioned in the issue, I think maybe the font size thing should be un-deprecated, and things that look like font sizes should be treated as values by default. This was ostensibly deprecated a long time ago but the message/warning got lost and I think it has become too established now.

@mattpap mattpap mentioned this pull request Oct 3, 2016
@mattpap mattpap force-pushed the mattpap/5273_no_deprecation_warnings branch from 6fd8b11 to fbf35fc Oct 4, 2016
@bryevdv bryevdv added the MIGRATION label Oct 4, 2016
@bryevdv
Copy link
Member

@bryevdv bryevdv commented Oct 4, 2016

MIGRATION to mention undeprecation

@mattpap mattpap added status: ready and removed status: WIP labels Oct 4, 2016
@bryevdv
Copy link
Member

@bryevdv bryevdv commented Oct 4, 2016

LGTM will merge when green

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Oct 4, 2016

sigh... ggplot_density.py strikes yet again. I checked out the branch and ran it locally just to make sure it works (it does). Will go ahead and merge.

@bryevdv bryevdv merged commit 1a606de into master Oct 4, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bryevdv bryevdv deleted the mattpap/5273_no_deprecation_warnings branch Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.