Remove old deprecations #5672

Merged
merged 10 commits into from Jan 10, 2017

Projects

None yet

2 participants

@mattpap
Contributor
mattpap commented Jan 8, 2017 edited
  • removed deprecations since 0.11.x
  • removed deprecations since 0.12.0

fixes #5664

@mattpap
Contributor
mattpap commented Jan 8, 2017

@bryevdv, how far we want to go? Should 0.12.0 deprecations also be removed?

@bryevdv
Member
bryevdv commented Jan 9, 2017

how far we want to go? Should 0.12.0 deprecations also be removed?

I'm not opposed to removing at least some of them

@mattpap
Contributor
mattpap commented Jan 9, 2017

I'm not sure what's wrong, but integration tests are pretty much one big traceback. I restarted it several times with no change.

@bryevdv
Member
bryevdv commented Jan 9, 2017

Looking at it, it seems to be some remote problem with selenium itself, but its hard to tell.

@bryevdv
Member
bryevdv commented Jan 9, 2017

Not sure if I missed this before but this looks more like a real error:

INTERNALERROR> FileNotFoundError: [Errno 2] No such file or directory: '/home/travis/build/bokeh/bokeh/tests/integration/annotations/screenshots/current__test_title__test_the_default_titles_settings_and_ensure_outside_any_axes.png'
@mattpap
Contributor
mattpap commented Jan 10, 2017

INTERNALERROR> FileNotFoundError: [Errno 2] No such file or directory: '/home/travis/build/bokeh/bokeh/tests/integration/annotations/screenshots/current__test_title__test_the_default_titles_settings_and_ensure_outside_any_axes.png'

I had enough with this testing "infrastructure". I had to modify tests and run them locally to learn that:

ValueError: expected an instance of type Title, got Title above - left of type str

is the underlying cause of integration test failure.

@bryevdv
Member
bryevdv commented Jan 10, 2017

. I had to modify tests and run them locally to learn that:

Thanks @mattpap that was the next step I was going to take today but you beat me to it. I will merge this now.

Agreed (and @birdsarah agrees too) that Selenium does not "blow up" nicely, but AFAIK it's the best option available for testing interactions automatically, and has absolutely caught what would have been serious bugs before previous releases. Maybe there is some custom tooling we can add around it to make things more accessible in the reports?

@bryevdv
Member
bryevdv commented Jan 10, 2017 edited

@mattpap actually, will merge later today. I want to:

  • add MIGRATION to the issue
  • start and add the 0.12.5 release notes migration guide as part of this PR (listing all the things that were removed)
@bryevdv
Member
bryevdv commented Jan 10, 2017

Migration notes added, will merge when green

@bryevdv bryevdv merged commit 4fbcfc0 into master Jan 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bryevdv bryevdv deleted the mattpap/5664_remove_old_deprecations branch Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment