Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Creates tempfile when output_filename is not writable (notebook) #5942
Several examples in python 2 seem to be reliably failing on Travis examples tests with e.g.
I note that, at least for that bar chart example, the script does not call
I think that is a mistake (I think all examples should set a filename explicitly), but it also seems to show some issue with this change and python 2?
This LGTM. It's probably worth adding a migration note about this (just trying to develop good fastidious habits around reporting things that change) This is the file:
A new section and short sentence or two under "Migration Guide" Once that's there I think we can merge!