New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates tempfile when output_filename is not writable (notebook) #5942

Merged
merged 5 commits into from Mar 3, 2017

Conversation

Projects
None yet
3 participants
@jsignell
Contributor

jsignell commented Mar 1, 2017

  • issues: fixes #5677
  • tests added / passed
  • release document entry (if new feature or API change)
@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Mar 2, 2017

Member

Several examples in python 2 seem to be reliably failing on Travis examples tests with e.g.

tests/examples/test_examples.py::test_file_examples[/home/travis/build/bokeh/bokeh/examples/plotting/file/bar_chart.py-example58] 
[INFO] Example run in 1.245s
[INFO] Example rendered in 0.352s
[JS] Error opening /home/travis/build/bokeh/bokeh/examples/plotting/file/bar_chart.html: No such file or directory
FAILED

I note that, at least for that bar chart example, the script does not call output_file:

https://github.com/bokeh/bokeh/blob/master/examples/plotting/file/bar_chart.py

I think that is a mistake (I think all examples should set a filename explicitly), but it also seems to show some issue with this change and python 2?

Member

bryevdv commented Mar 2, 2017

Several examples in python 2 seem to be reliably failing on Travis examples tests with e.g.

tests/examples/test_examples.py::test_file_examples[/home/travis/build/bokeh/bokeh/examples/plotting/file/bar_chart.py-example58] 
[INFO] Example run in 1.245s
[INFO] Example rendered in 0.352s
[JS] Error opening /home/travis/build/bokeh/bokeh/examples/plotting/file/bar_chart.html: No such file or directory
FAILED

I note that, at least for that bar chart example, the script does not call output_file:

https://github.com/bokeh/bokeh/blob/master/examples/plotting/file/bar_chart.py

I think that is a mistake (I think all examples should set a filename explicitly), but it also seems to show some issue with this change and python 2?

@mattpap

This comment has been minimized.

Show comment
Hide comment
@mattpap

mattpap Mar 2, 2017

Contributor

it also seems to show some issue with this change and python 2

phantomjs part of examples testing is done only on 2.7, so it doesn't work at all (presumably, I didn't look at the code).

Contributor

mattpap commented Mar 2, 2017

it also seems to show some issue with this change and python 2

phantomjs part of examples testing is done only on 2.7, so it doesn't work at all (presumably, I didn't look at the code).

@mattpap mattpap added the status: WIP label Mar 2, 2017

Show outdated Hide outdated bokeh/io.py
Show outdated Hide outdated bokeh/io.py
Show outdated Hide outdated bokeh/io.py
Show outdated Hide outdated bokeh/io.py
Show outdated Hide outdated bokeh/io.py
Show outdated Hide outdated bokeh/io.py
Show outdated Hide outdated bokeh/io.py

@bryevdv bryevdv added status: accepted and removed status: WIP labels Mar 3, 2017

@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Mar 3, 2017

Member

This LGTM. It's probably worth adding a migration note about this (just trying to develop good fastidious habits around reporting things that change) This is the file:

https://github.com/bokeh/bokeh/blob/master/sphinx/source/docs/releases/0.12.5.rst

A new section and short sentence or two under "Migration Guide" Once that's there I think we can merge!

Member

bryevdv commented Mar 3, 2017

This LGTM. It's probably worth adding a migration note about this (just trying to develop good fastidious habits around reporting things that change) This is the file:

https://github.com/bokeh/bokeh/blob/master/sphinx/source/docs/releases/0.12.5.rst

A new section and short sentence or two under "Migration Guide" Once that's there I think we can merge!

@bryevdv bryevdv merged commit f766a37 into bokeh:master Mar 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment