New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12.7 docs/examples #6750

Merged
merged 13 commits into from Aug 28, 2017

Conversation

Projects
None yet
3 participants
@bryevdv
Member

bryevdv commented Aug 8, 2017

@bokeh/dev if there are smaller docs/examples tasks let's collect them in this one PR.

@bryevdv bryevdv changed the title from add split stacked example to 0.12.7 docs/examples Aug 8, 2017

@mattpap mattpap added the status: WIP label Aug 9, 2017

@bryevdv bryevdv added status: ready and removed status: WIP labels Aug 28, 2017

Show outdated Hide outdated README.md
@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Aug 28, 2017

Member

I don;t know why the integration test is failing it started failing the branding update commit, which changed no code

Member

bryevdv commented Aug 28, 2017

I don;t know why the integration test is failing it started failing the branding update commit, which changed no code

@mattpap

This comment has been minimized.

Show comment
Hide comment
@mattpap

mattpap Aug 28, 2017

Contributor

I don;t know why the integration test is failing it started failing the branding update commit, which changed no code.

No clue either. The report is useless. I would suspect a browser version change to be responsible, though looking at metadata, I think it's the same (at last major number).

Contributor

mattpap commented Aug 28, 2017

I don;t know why the integration test is failing it started failing the branding update commit, which changed no code.

No clue either. The report is useless. I would suspect a browser version change to be responsible, though looking at metadata, I think it's the same (at last major number).

@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Aug 28, 2017

Member

I guess we will see in a few minutes when the latest merges to master finish, whether this is a general problem or confined to this branch.

Member

bryevdv commented Aug 28, 2017

I guess we will see in a few minutes when the latest merges to master finish, whether this is a general problem or confined to this branch.

@mattpap

This comment has been minimized.

Show comment
Hide comment
@mattpap

mattpap Aug 28, 2017

Contributor

btw. What's up with the last horizontal tick in plotting/file/custom_datetime_axis?

image

Contributor

mattpap commented Aug 28, 2017

btw. What's up with the last horizontal tick in plotting/file/custom_datetime_axis?

image

@mattpap

This comment has been minimized.

Show comment
Hide comment
@mattpap

mattpap Aug 28, 2017

Contributor

I compared all packages used for testing in this PR and the last good one, and all are the same.

Contributor

mattpap commented Aug 28, 2017

I compared all packages used for testing in this PR and the last good one, and all are the same.

@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Aug 28, 2017

Member

Oh, I changed it to use a much simpler tick override mechanism... but that's going to make any extra ticks look stupid... bounds would fix that

Member

bryevdv commented Aug 28, 2017

Oh, I changed it to use a much simpler tick override mechanism... but that's going to make any extra ticks look stupid... bounds would fix that

@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Aug 28, 2017

Member

Master is failing now too: https://travis-ci.org/bokeh/bokeh/jobs/269230310 This is a general issue

Member

bryevdv commented Aug 28, 2017

Master is failing now too: https://travis-ci.org/bokeh/bokeh/jobs/269230310 This is a general issue

@canavandl

This comment has been minimized.

Show comment
Hide comment
@canavandl

canavandl Aug 28, 2017

Contributor

The failing test (test_scale_both_resizes_width_and_height_with_fixed_aspect_ratio) passes locally for me. The issue appears to originate w/ SauceLabs.

Yes, it appears SauceLabs has upgraded from Firefox 45 -> Firefox 50.

Contributor

canavandl commented Aug 28, 2017

The failing test (test_scale_both_resizes_width_and_height_with_fixed_aspect_ratio) passes locally for me. The issue appears to originate w/ SauceLabs.

Yes, it appears SauceLabs has upgraded from Firefox 45 -> Firefox 50.

@mattpap

This comment has been minimized.

Show comment
Hide comment
@mattpap

mattpap Aug 28, 2017

Contributor

It gets even better in https://travis-ci.org/bokeh/bokeh/jobs/269230310 (master after PR #6823).

Contributor

mattpap commented Aug 28, 2017

It gets even better in https://travis-ci.org/bokeh/bokeh/jobs/269230310 (master after PR #6823).

@mattpap

This comment has been minimized.

Show comment
Hide comment
@mattpap

mattpap Aug 28, 2017

Contributor

Yes, it appears SauceLabs has upgraded from Firefox 45 -> Firefox 50.

Metadata doesn't confirm this: https://saucelabs.com/beta/tests/01a511ac16314c7aabde1c48752bb96d/metadata#25. The same for other failing test jobs.

Contributor

mattpap commented Aug 28, 2017

Yes, it appears SauceLabs has upgraded from Firefox 45 -> Firefox 50.

Metadata doesn't confirm this: https://saucelabs.com/beta/tests/01a511ac16314c7aabde1c48752bb96d/metadata#25. The same for other failing test jobs.

@canavandl

This comment has been minimized.

Show comment
Hide comment
@canavandl

canavandl Aug 28, 2017

Contributor

The Travis logs say so: https://travis-ci.org/bokeh/bokeh/jobs/269213598#L337 wait that's travis. sorry for the noise

Contributor

canavandl commented Aug 28, 2017

The Travis logs say so: https://travis-ci.org/bokeh/bokeh/jobs/269213598#L337 wait that's travis. sorry for the noise

@mattpap

This comment has been minimized.

Show comment
Hide comment
@mattpap

mattpap Aug 28, 2017

Contributor

OK, that's bloody mess. I think we just have to force version 45, if possible, and later update our tests to work with more modern versions.

Contributor

mattpap commented Aug 28, 2017

OK, that's bloody mess. I think we just have to force version 45, if possible, and later update our tests to work with more modern versions.

@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Aug 28, 2017

Member

wheres a passing test link, maybe compare metadata against that

Member

bryevdv commented Aug 28, 2017

wheres a passing test link, maybe compare metadata against that

@mattpap

This comment has been minimized.

Show comment
Hide comment
@mattpap

mattpap Aug 28, 2017

Contributor

We depend on the default version (https://github.com/bokeh/bokeh/blob/master/tests/integration/integration_tests_plugin.py#L65), so this (and a few other references) has to be fixed.

Contributor

mattpap commented Aug 28, 2017

We depend on the default version (https://github.com/bokeh/bokeh/blob/master/tests/integration/integration_tests_plugin.py#L65), so this (and a few other references) has to be fixed.

@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Aug 28, 2017

Member

Also can configure here: https://github.com/bokeh/bokeh/blob/master/tests/integration/integration_tests_plugin.py#L39

But doesn't metadata indicate the version has not changed?

Member

bryevdv commented Aug 28, 2017

Also can configure here: https://github.com/bokeh/bokeh/blob/master/tests/integration/integration_tests_plugin.py#L39

But doesn't metadata indicate the version has not changed?

@mattpap

This comment has been minimized.

Show comment
Hide comment
@mattpap

mattpap Aug 28, 2017

Contributor

wheres a passing test link, maybe compare metadata against that

But doesn't metadata indicate the version has not changed?

Yeah, e.g. PR #6823 (sliders styling) also has FF 50 installed, but that's unrelated to sauce labs, because we don't run FF locally.

Contributor

mattpap commented Aug 28, 2017

wheres a passing test link, maybe compare metadata against that

But doesn't metadata indicate the version has not changed?

Yeah, e.g. PR #6823 (sliders styling) also has FF 50 installed, but that's unrelated to sauce labs, because we don't run FF locally.

@mattpap

This comment has been minimized.

Show comment
Hide comment
@mattpap

mattpap Aug 28, 2017

Contributor

In the case of lack of ideas to fix this, we can temporarily XFail this test (we have one similar already XFailed). At this point I have no idea what's wrong.

Contributor

mattpap commented Aug 28, 2017

In the case of lack of ideas to fix this, we can temporarily XFail this test (we have one similar already XFailed). At this point I have no idea what's wrong.

@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Aug 28, 2017

Member

me either, I will xfail the four tests...

Member

bryevdv commented Aug 28, 2017

me either, I will xfail the four tests...

@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Aug 28, 2017

Member

Not sure if it's coincidence but all four failing tests were the last tests in their respective files.

Member

bryevdv commented Aug 28, 2017

Not sure if it's coincidence but all four failing tests were the last tests in their respective files.

@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Aug 28, 2017

Member

passing now will merge when green

Member

bryevdv commented Aug 28, 2017

passing now will merge when green

@bryevdv bryevdv merged commit a57cac7 into master Aug 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bryevdv bryevdv deleted the docs_examples_0127 branch Aug 28, 2017

@bryevdv bryevdv added this to the 0.12.7 milestone Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment