Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Rename ci scripts, use dot (.) instead of colon (:) #8089 #8090

Merged
merged 2 commits into from Jul 20, 2018

Conversation

pratapvardhan
Copy link
Contributor

@pratapvardhan pratapvardhan commented Jul 20, 2018

Rename ci scripts, use dot (.) instead of colon (:)

@bryevdv
Copy link
Member

bryevdv commented Jul 20, 2018

Not sure what the issue is offhand, the first build stage is failing with this:

/home/travis/.travis/job_stages: line 78: scripts/ci/install.build: Permission denied

which causes all subsequent stages to be aborted.

@mattpap
Copy link
Contributor

mattpap commented Jul 20, 2018

Permission denied

Executable bits were removed from scripts' permissions. It's visible in "Files changed" tab.

@bryevdv
Copy link
Member

bryevdv commented Jul 20, 2018

@pratapvardhan hopefully this will allow you to add the +x on windows:

https://www.jerriepelser.com/blog/execute-permissions-with-git/

@bryevdv
Copy link
Member

bryevdv commented Jul 20, 2018

Build stages seem to be proceeding now

@bryevdv
Copy link
Member

bryevdv commented Jul 20, 2018

@pratapvardhan it looks like a few of the files did not get updated back still:

screen shot 2018-07-20 at 08 20 01

looks like also install.codebase and install.downtream

@pratapvardhan
Copy link
Contributor Author

@bryevdv -- 46cf7d2 did change the permissions for the 18 files, the diff seems to be misleading.. First build seems to have passed, I'll wait till the job finishes and take a lot, if something's amiss.

@bryevdv
Copy link
Member

bryevdv commented Jul 20, 2018

The diff is definitely misleading, but all the build stages and jobs have passed, so I will merge this now, thanks @pratapvardhan

@bryevdv bryevdv merged commit c5363c3 into bokeh:master Jul 20, 2018
@pratapvardhan pratapvardhan deleted the refci branch July 22, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci scripts with colon in filenames are not valid on windows
3 participants