New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webdriver_control and default to reuse #8329

Merged
merged 2 commits into from Oct 15, 2018

Conversation

Projects
None yet
1 participant
@bryevdv
Copy link
Member

bryevdv commented Oct 14, 2018

Adds a module level object to control and manage webdriver creation, defaults to re-using selenium webdrivers.

  • tests added / passed

@bryevdv bryevdv added this to the 1.0 milestone Oct 14, 2018

@bryevdv bryevdv force-pushed the bryanv/reuse_webdriver branch from e487c3c to 34e0300 Oct 14, 2018

@bryevdv bryevdv force-pushed the bryanv/reuse_webdriver branch from 34e0300 to 91abec1 Oct 14, 2018

@bryevdv

This comment has been minimized.

Copy link
Member Author

bryevdv commented Oct 15, 2018

Not sure what's up with the Appveyor build for this branch. The tests finish and pytest exits but the job does not finish.

@bryevdv bryevdv merged commit c58430c into master Oct 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bryevdv bryevdv deleted the bryanv/reuse_webdriver branch Oct 15, 2018

xavArtley pushed a commit to xavArtley/bokeh that referenced this pull request Oct 15, 2018

add webdriver_control and default to reuse (bokeh#8329)
* add webdriver_control and default to reuse

* more carefully manage test sub processes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment